Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang][test] Split AArch64 target feature checks across multiple lines. NFC #99365

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[clang][test] Split AArch64 target feature checks across multiple lines. NFC #99365

merged 1 commit into from
Jul 18, 2024

Conversation

jroelofs
Copy link
Contributor

Whenever these tests change, it's difficult to see why they don't match, and the diff after you've fixed them isn't easy to grok. By splitting them with a sed pipe, we fix both issues simultaneously.

@jroelofs
[clang][test] Split AArch64 target feature checks across multiple lin…
9163c34 
…es. NFC

Whenever these tests change, it's difficult to see why they don't match, and
the diff after you've fixed them isn't easy to grok.  By splitting them with a
sed pipe, we fix both issues simultaneously.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jul 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 17, 2024

@llvm/pr-subscribers-clang

Author: Jon Roelofs (jroelofs)

Changes

Whenever these tests change, it's difficult to see why they don't match, and the diff after you've fixed them isn't easy to grok. By splitting them with a sed pipe, we fix both issues simultaneously.

Patch is 28.91 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/99365.diff

1 Files Affected:

  • (modified) clang/test/Preprocessor/aarch64-target-features.c (+303-48)
diff --git a/clang/test/Preprocessor/aarch64-target-features.c b/clang/test/Preprocessor/aarch64-target-features.c
index 71cc36acf3f0e..d811cb36e28d8 100644
--- a/clang/test/Preprocessor/aarch64-target-features.c
+++ b/clang/test/Preprocessor/aarch64-target-features.c
@@ -291,54 +291,309 @@
 // RUN: %clang -target aarch64 -mtune=CYCLONE -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MTUNE-CYCLONE %s
 // CHECK-MTUNE-CYCLONE: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8a"
 
-// RUN: %clang -target aarch64 -mcpu=apple-a7 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a8 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a9 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a10 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A10 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a11 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A11 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a12 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
-// RUN: %clang -target aarch64 -mcpu=apple-a13 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A13 %s
-// RUN: %clang -target aarch64 -mcpu=apple-s4 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
-// RUN: %clang -target aarch64 -mcpu=apple-s5 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
-// RUN: %clang -target aarch64 -mcpu=cyclone -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a34 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A34 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a35 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A35 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a53 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A53 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a57 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A57 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a72 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A72 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-a73 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-CORTEX-A73 %s
-// RUN: %clang -target aarch64 -mcpu=cortex-r82 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-CORTEX-R82 %s
-// RUN: %clang -target aarch64 -mcpu=exynos-m3 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-M3 %s
-// RUN: %clang -target aarch64 -mcpu=exynos-m4 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-M4 %s
-// RUN: %clang -target aarch64 -mcpu=exynos-m5 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-M4 %s
-// RUN: %clang -target aarch64 -mcpu=kryo -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-KRYO %s
-// RUN: %clang -target aarch64 -mcpu=thunderx2t99 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-THUNDERX2T99 %s
-// RUN: %clang -target aarch64 -mcpu=a64fx -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-A64FX %s
-// RUN: %clang -target aarch64 -mcpu=carmel -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-MCPU-CARMEL %s
-// CHECK-MCPU-APPLE-A7: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-APPLE-A10: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+lor" "-target-feature" "+neon" "-target-feature" "+pan" "-target-feature" "+perfmon" "-target-feature" "+rdm" "-target-feature" "+sha2" "-target-feature" "+vh"
-// CHECK-MCPU-APPLE-A11: "-cc1"{{.*}} "-triple" "aarch64{{.*}}"{{.*}}"-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.2a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rdm" "-target-feature" "+sha2"
-// CHECK-MCPU-APPLE-A12: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.3a" "-target-feature" "+aes" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sha2"
-// CHECK-MCPU-A34: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-APPLE-A13: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.4a" "-target-feature" "+aes" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+dotprod" "-target-feature" "+fp-armv8" "-target-feature" "+fp16fml" "-target-feature" "+fullfp16" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sha2" "-target-feature" "+sha3"
-// CHECK-MCPU-A35: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-A53: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-A57: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-A72: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-CORTEX-A73: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-CORTEX-R82: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8r" "-target-feature" "+ccdp" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+dotprod" "-target-feature" "+flagm" "-target-feature" "+fp-armv8" "-target-feature" "+fp16fml" "-target-feature" "+fullfp16" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+predres" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sb" "-target-feature" "+ssbs"
-// CHECK-MCPU-M3: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-M4: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.2a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+dotprod" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rdm" "-target-feature" "+sha2"
-// CHECK-MCPU-KRYO: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+sha2"
-// CHECK-MCPU-THUNDERX2T99: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.1a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+rdm" "-target-feature" "+sha2
-// CHECK-MCPU-A64FX: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.2a" "-target-feature" "+aes" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rdm" "-target-feature" "+sha2" "-target-feature" "+sve"
-// CHECK-MCPU-CARMEL: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.2a" "-target-feature" "+aes" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+ras" "-target-feature" "+rdm" "-target-feature" "+sha2"
-
-// RUN: %clang -target x86_64-apple-macosx -arch arm64 -### -c %s 2>&1 | FileCheck --check-prefix=CHECK-ARCH-ARM64 %s
-// CHECK-ARCH-ARM64: "-target-cpu" "apple-m1" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.4a" "-target-feature" "+aes" "-target-feature" "+altnzcv" "-target-feature" "+ccdp" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+dotprod" "-target-feature" "+fp-armv8" "-target-feature" "+fp16fml" "-target-feature" "+fptoint" "-target-feature" "+fullfp16" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+predres" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sb" "-target-feature" "+sha2" "-target-feature" "+sha3" "-target-feature" "+specrestrict" "-target-feature" "+ssbs"
-
-// RUN: %clang -target x86_64-apple-macosx -arch arm64_32 -### -c %s 2>&1 | FileCheck --check-prefix=CHECK-ARCH-ARM64_32 %s
-// CHECK-ARCH-ARM64_32: "-target-cpu" "apple-s4" "-target-feature" "+zcm" "-target-feature" "+zcz" "-target-feature" "+v8.3a" "-target-feature" "+aes" "-target-feature" "+complxnum" "-target-feature" "+crc" "-target-feature" "+fp-armv8" "-target-feature" "+fullfp16" "-target-feature" "+jsconv" "-target-feature" "+lse" "-target-feature" "+neon" "-target-feature" "+pauth" "-target-feature" "+perfmon" "-target-feature" "+ras" "-target-feature" "+rcpc" "-target-feature" "+rdm" "-target-feature" "+sha2"
+// RUN: %clang -target aarch64 -mcpu=apple-a7 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a8 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a9 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a10 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A10 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a11 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A11 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a12 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
+// RUN: %clang -target aarch64 -mcpu=apple-a13 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A13 %s
+// RUN: %clang -target aarch64 -mcpu=apple-s4 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
+// RUN: %clang -target aarch64 -mcpu=apple-s5 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A12 %s
+// RUN: %clang -target aarch64 -mcpu=cyclone -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-APPLE-A7 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a34 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A34 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a35 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A35 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a53 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A53 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a57 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A57 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a72 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A72 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-a73 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-CORTEX-A73 %s
+// RUN: %clang -target aarch64 -mcpu=cortex-r82 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-CORTEX-R82 %s
+// RUN: %clang -target aarch64 -mcpu=exynos-m3 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-M3 %s
+// RUN: %clang -target aarch64 -mcpu=exynos-m4 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-M4 %s
+// RUN: %clang -target aarch64 -mcpu=exynos-m5 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-M4 %s
+// RUN: %clang -target aarch64 -mcpu=kryo -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-KRYO %s
+// RUN: %clang -target aarch64 -mcpu=thunderx2t99 -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-THUNDERX2T99 %s
+// RUN: %clang -target aarch64 -mcpu=a64fx -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-A64FX %s
+// RUN: %clang -target aarch64 -mcpu=carmel -### -c %s 2>&1 | sed -e 's/"-/\n"-/g' | FileCheck -check-prefix=CHECK-MCPU-CARMEL %s
+// CHECK-MCPU-APPLE-A7-LABEL: "-target-cpu" "apple-a7"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+zcm"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+zcz"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-APPLE-A7-NEXT: "-target-abi"
+// CHECK-MCPU-APPLE-A10-LABEL: "-target-cpu" "apple-a10"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+zcm"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+zcz"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+lor"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+pan"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+rdm"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-feature" "+vh"
+// CHECK-MCPU-APPLE-A10-NEXT: "-target-abi"
+// CHECK-MCPU-APPLE-A11-LABEL: "-target-cpu" "apple-a11"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+zcm"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+zcz"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+v8.2a"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+fullfp16"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+lse"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+ras"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+rdm"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-APPLE-A11-NEXT: "-target-abi"
+// CHECK-MCPU-APPLE-A12-LABEL: "-target-cpu" "apple-a12"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+zcm"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+zcz"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+v8.3a"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+complxnum"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+fullfp16"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+jsconv"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+lse"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+pauth"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+ras"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+rcpc"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+rdm"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-APPLE-A12-NEXT: "-target-abi"
+// CHECK-MCPU-A34-LABEL: "-target-cpu" "cortex-a34"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-A34-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-A34-NEXT: "-target-abi"
+// CHECK-MCPU-APPLE-A13-LABEL: "-target-cpu" "apple-a13"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+zcm"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+zcz"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+v8.4a"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+complxnum"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+dotprod"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+fp16fml"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+fullfp16"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+jsconv"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+lse"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+pauth"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+ras"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+rcpc"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+rdm"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-feature" "+sha3"
+// CHECK-MCPU-APPLE-A13-NEXT: "-target-abi"
+// CHECK-MCPU-A35-LABEL: "-target-cpu" "cortex-a35"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-A35-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-A35-NEXT: "-target-abi"
+// CHECK-MCPU-A53-LABEL: "-target-cpu" "cortex-a53"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-A53-NEXT: "-target-feature" "+sha2"
+// CHECK-MCPU-A53-NEXT: "-target-abi"
+// CHECK-MCPU-A57-LABEL: "-target-cpu" "cortex-a57"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+v8a"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+aes"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+crc"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+fp-armv8"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+neon"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+perfmon"
+// CHECK-MCPU-A57-NEXT: "-target-feature" "+sha2"
+/...
[truncated]

tmatheson-arm
tmatheson-arm approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tmatheson-arm tmatheson-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks.

@jroelofs jroelofs merged commit c0c4ad5 into llvm:main Jul 18, 2024
9 checks passed
@jroelofs
Copy link
Contributor Author

This broke the aix-ppc64 bot:

https://lab.llvm.org/buildbot/#/builders/64/builds/335

Must have a different version of sed than I do :(

jroelofs added a commit that referenced this pull request Jul 18, 2024
@jroelofs
fixup! [clang][test] Split AArch64 target feature checks across multi…
05275b0 
…ple lines. NFC (#99365)

Looks like sed on the ppc64-aix bot does not support the '\n' literal. Let's
try using `tr` to perform that substitution. Failing that, we can revert.
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 18, 2024

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-sie-win running on sie-win-worker while building clang at step 7 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/1896

Here is the relevant piece of the build log for the reference:

Step 7 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Preprocessor/aarch64-target-features.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-linux-gnu -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-linux-gnu -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c'
# RUN: at line 2
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target arm64-none-linux-gnu -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target arm64-none-linux-gnu -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c'
# RUN: at line 68
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-elf -march=armv8-r -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-R-PROFILE
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-elf -march=armv8-r -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-R-PROFILE
# RUN: at line 69
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target arm64-none-linux-gnu -march=armv8-r -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-R-PROFILE
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target arm64-none-linux-gnu -march=armv8-r -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-R-PROFILE
# RUN: at line 72
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-elf -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-A-PROFILE
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-elf -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-A-PROFILE
# RUN: at line 73
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-elf -march=armv8-a -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-A-PROFILE
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-elf -march=armv8-a -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-A-PROFILE
# RUN: at line 74
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target arm64-none-linux-gnu -march=armv8-a -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-A-PROFILE
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target arm64-none-linux-gnu -march=armv8-a -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-A-PROFILE
# RUN: at line 77
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64_be-none-elf -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -check-prefix CHECK-BIGENDIAN
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64_be-none-elf -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -check-prefix CHECK-BIGENDIAN
# RUN: at line 80
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-linux-gnu -march=armv8-a+crypto -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe --check-prefix=CHECK-FEAT-CRYPTO Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-linux-gnu -march=armv8-a+crypto -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' --check-prefix=CHECK-FEAT-CRYPTO 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c'
# RUN: at line 81
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target arm64-none-linux-gnu -march=armv8-a+crypto -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe --check-prefix=CHECK-FEAT-CRYPTO Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target arm64-none-linux-gnu -march=armv8-a+crypto -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' --check-prefix=CHECK-FEAT-CRYPTO 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c'
# RUN: at line 86
z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe -target aarch64-none-linux-gnu -march=armv8.4-a+crypto -x c -E -dM Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c -o - | z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe --check-prefix=CHECK-FEAT-CRYPTO-8_4 Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\clang.exe' -target aarch64-none-linux-gnu -march=armv8.4-a+crypto -x c -E -dM 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c' -o -
# executed command: 'z:\b\llvm-clang-x86_64-sie-win\build\bin\filecheck.exe' --check-prefix=CHECK-FEAT-CRYPTO-8_4 'Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\Preprocessor\aarch64-target-features.c'
# RUN: at line 87
...

jroelofs added a commit that referenced this pull request Jul 18, 2024
@jroelofs
Revert "[clang][test] Split AArch64 target feature checks across mult…
06518ce 
…iple lines. NFC (#99365)"

This reverts commit c0c4ad5.

And the fixup broke another bot. Darn.

https://lab.llvm.org/buildbot/#/builders/46/builds/1896
jroelofs added a commit that referenced this pull request Jul 18, 2024
@jroelofs
Revert "[clang][test] Split AArch64 target feature checks across mult…
6c6baf0 
…iple lines. NFC (#99365)"

This reverts commit 06518ce.
This reverts commit 05275b0.
This reverts commit c0c4ad5.
Harini0924 pushed a commit to Harini0924/llvm-project that referenced this pull request Jul 22, 2024
@jroelofs @Harini0924
[clang][test] Split AArch64 target feature checks across multiple lin…
f6cdad5 
…es. NFC (llvm#99365)

Whenever these tests change, it's difficult to see why they don't match,
and the diff after you've fixed them isn't easy to grok. By splitting
them with a sed pipe, we fix both issues simultaneously.
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@jroelofs @sgundapa
[clang][test] Split AArch64 target feature checks across multiple lin…
d40186b 
…es. NFC (llvm#99365)

Whenever these tests change, it's difficult to see why they don't match,
and the diff after you've fixed them isn't easy to grok. By splitting
them with a sed pipe, we fix both issues simultaneously.
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@jroelofs @sgundapa
fixup! [clang][test] Split AArch64 target feature checks across multi…
f4639c2 
…ple lines. NFC (llvm#99365)

Looks like sed on the ppc64-aix bot does not support the '\n' literal. Let's
try using `tr` to perform that substitution. Failing that, we can revert.
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@jroelofs @sgundapa
Revert "[clang][test] Split AArch64 target feature checks across mult…
59fe7d8 
…iple lines. NFC (llvm#99365)"

This reverts commit c0c4ad5.

And the fixup broke another bot. Darn.

https://lab.llvm.org/buildbot/#/builders/46/builds/1896
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
@jroelofs @sgundapa
Revert "[clang][test] Split AArch64 target feature checks across mult…
d3774cf 
…iple lines. NFC (llvm#99365)"

This reverts commit 06518ce.
This reverts commit 05275b0.
This reverts commit c0c4ad5.
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@jroelofs @yuxuanchen1997
[clang][test] Split AArch64 target feature checks across multiple lin…
f251ffe 
…es. NFC (#99365)

Whenever these tests change, it's difficult to see why they don't match,
and the diff after you've fixed them isn't easy to grok. By splitting
them with a sed pipe, we fix both issues simultaneously.
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@jroelofs @yuxuanchen1997
fixup! [clang][test] Split AArch64 target feature checks across multi…
5434cc7 
…ple lines. NFC (#99365)

Summary:
Looks like sed on the ppc64-aix bot does not support the '\n' literal. Let's
try using `tr` to perform that substitution. Failing that, we can revert.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251369
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@jroelofs @yuxuanchen1997
Revert "[clang][test] Split AArch64 target feature checks across mult…
788ffe3 
…iple lines. NFC (#99365)"

Summary:
This reverts commit c0c4ad5.

And the fixup broke another bot. Darn.

https://lab.llvm.org/buildbot/#/builders/46/builds/1896

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251372
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@jroelofs @yuxuanchen1997
Revert "[clang][test] Split AArch64 target feature checks across mult…
0937a24 
…iple lines. NFC (#99365)"

Summary:
This reverts commit 06518ce.
This reverts commit 05275b0.
This reverts commit c0c4ad5.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatheson-arm tmatheson-arm tmatheson-arm approved these changes

@ahmedbougacha ahmedbougacha Awaiting requested review from ahmedbougacha

Assignees
No one assigned
Labels
clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jroelofs @llvmbot @llvm-ci @tmatheson-arm