[clang-tidy][NFC] Fix gsl::not_null template parameter #99472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tidy Author: Rafael Stahl (rafzi) Changes
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr Full diff: https://github.com/llvm/llvm-project/pull/99472.diff 2 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
index 5783280478dc1..57c4829431e76 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
@@ -35,7 +35,7 @@ Examples:
int* x;
std::unique_ptr<int> x;
std::shared_ptr<int> x;
- gsl::not_null<int> x;
+ gsl::not_null<int*> x;
};
// Bad, rvalue reference member
diff --git a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
index 5a5d05bb4e94e..e3864be134da3 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
@@ -18,7 +18,7 @@ struct Ok {
const int *pc;
std::unique_ptr<int> up;
std::shared_ptr<int> sp;
- gsl::not_null<int> n;
+ gsl::not_null<int*> n;
};
struct ConstMember {
@@ -60,7 +60,7 @@ struct Ok2 {
const Foo *pc;
std::unique_ptr<Foo> up;
std::shared_ptr<Foo> sp;
- gsl::not_null<Foo> n;
+ gsl::not_null<Foo*> n;
};
struct ConstMember2 {
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Rafael Stahl (rafzi) Changes
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr Full diff: https://github.com/llvm/llvm-project/pull/99472.diff 2 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
index 5783280478dc1..57c4829431e76 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst
@@ -35,7 +35,7 @@ Examples:
int* x;
std::unique_ptr<int> x;
std::shared_ptr<int> x;
- gsl::not_null<int> x;
+ gsl::not_null<int*> x;
};
// Bad, rvalue reference member
diff --git a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
index 5a5d05bb4e94e..e3864be134da3 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp
@@ -18,7 +18,7 @@ struct Ok {
const int *pc;
std::unique_ptr<int> up;
std::shared_ptr<int> sp;
- gsl::not_null<int> n;
+ gsl::not_null<int*> n;
};
struct ConstMember {
@@ -60,7 +60,7 @@ struct Ok2 {
const Foo *pc;
std::unique_ptr<Foo> up;
std::shared_ptr<Foo> sp;
- gsl::not_null<Foo> n;
+ gsl::not_null<Foo*> n;
};
struct ConstMember2 {
|
EugeneZelenko
requested review from
PiotrZSL,
SimplyDanny,
5chmidti and
HerrCai0907
5chmidti
approved these changes
Jul 18, 2024
PiotrZSL
approved these changes
Jul 18, 2024
sgundapa
pushed a commit
to sgundapa/upstream_effort
that referenced
this pull request
Jul 23, 2024
`T` is expected to be a pointer type. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: `T` is expected to be a pointer type. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tis expected to be a pointer type.https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-nullptr