Jump to conversation
Unresolved conversations (2)
@overmighty overmighty Jul 19, 2024
Should depend on `libc.src.__support.FPUtil.generic.add_sub` instead.
libc/src/math/generic/CMakeLists.txt
@overmighty overmighty Jul 19, 2024
Header guards should precede everything except the file header with license information.
libc/src/math/fadd.h
Resolved conversations (3)
@lntue lntue Jul 19, 2024
Can you also add to other architectures under `linux`?
libc/config/linux/x86_64/entrypoints.txt
@lntue lntue Jul 19, 2024
nit: remove extra empty line
Outdated
libc/src/math/generic/fadd.cpp
@lntue lntue Jul 19, 2024
`libc.src.__support.macros.properties.types` is not needed.
Outdated
libc/src/math/generic/CMakeLists.txt