Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Add missing python binding for clang_getUnqualifiedType and clang_getNonReferenceType #99793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brendene
Copy link

These are present in clang/include/clang-c/Index.h but not exported in the python bindings

This fixes #63235

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jul 21, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 21, 2024

@llvm/pr-subscribers-clang

Author: None (brendene)

Changes

These are present in clang/include/clang-c/Index.h but not exported in the python bindings

This fixes #63235


Full diff: https://github.com/llvm/llvm-project/pull/99793.diff

1 Files Affected:

  • (modified) clang/bindings/python/clang/cindex.py (+16)
diff --git a/clang/bindings/python/clang/cindex.py b/clang/bindings/python/clang/cindex.py
index be024da5e005c..8de25e385473d 100644
--- a/clang/bindings/python/clang/cindex.py
+++ b/clang/bindings/python/clang/cindex.py
@@ -2487,6 +2487,20 @@ def get_canonical(self):
         """
         return conf.lib.clang_getCanonicalType(self)
 
+    def get_unqualified(self):
+        """
+        Return the unqualified variant of the given type, removing as little sugar as possible.
+        """
+
+        return conf.lib.clang_getUnqualifiedType(self)
+
+    def get_non_reference(self):
+        """
+        Returns the type that the reference refers to, otherwise the type itself.
+        """
+
+        return conf.lib.clang_getNonReferenceType(self)
+
     def is_const_qualified(self):
         """Determine whether a Type has the "const" qualifier set.
 
@@ -3738,6 +3752,8 @@ def write_main_file_to_stdout(self):
     ("clang_getFieldDeclBitWidth", [Cursor], c_int),
     ("clang_getCanonicalCursor", [Cursor], Cursor, Cursor.from_cursor_result),
     ("clang_getCanonicalType", [Type], Type, Type.from_result),
+    ("clang_getUnqualifiedType", [Type], Type, Type.from_result),
+    ("clang_getNonReferenceType", [Type], Type, Type.from_result),
     ("clang_getChildDiagnostics", [Diagnostic], c_object_p),
     ("clang_getCompletionAvailability", [c_void_p], c_int),
     ("clang_getCompletionBriefComment", [c_void_p], _CXString, _CXString.from_result),

@brendene brendene changed the title Add missing python binding for clang_getUnqualifiedType and clang_getNonReferenceType [clang] Add missing python binding for clang_getUnqualifiedType and clang_getNonReferenceType Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing functionality in clang python binding
2 participants