Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The socket timeout is unusually short (5s). Increase, or make it configurable? #55

Open
PiDelport opened this issue Sep 7, 2015 · 1 comment

Comments

@PiDelport
Copy link

@PiDelport PiDelport commented Sep 7, 2015

PyrasiteIPC appears to hardcode the socket timeout to 5 seconds, which is very low.

My first attempt at using Pyrasite was to execute some diagnostic code, which took longer than 5 seconds to execute, resulting in a timeout and disconnection. I had to read and modify my copy of the source in order to remove the timeout and make it usable.

To avoid surprising newcomers with this, I think it would be a good idea to increase the default timeout to 30 seconds (or more, or disable it?). Many invocations one might want to run with Pyrasite probably take more than 5 seconds to execute.

In addition, it's probably a good idea to expose a --timeout option to make the timeout user-configurable, for users that don't want the default.

@ulope

This comment has been minimized.

Copy link

@ulope ulope commented Aug 2, 2016

I just ran into this as well. A configurable timeout would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.