Skip to content

Commit 080683f

Browse files
crishpeenliterat
crishpeen
authored and
literat
committed
Test: Temporarily disable all visual tests and SCSS loading
1 parent 1cbfaf0 commit 080683f

File tree

8 files changed

+135
-81
lines changed

8 files changed

+135
-81
lines changed

‎packages/web/src/scss/components/index.scss‎

Lines changed: 37 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,37 @@
1-
@forward 'Accordion';
2-
@forward 'Alert';
3-
@forward 'Breadcrumbs';
4-
@forward 'Button';
5-
@forward 'Checkbox';
6-
@forward 'Collapse';
7-
@forward 'Container';
8-
@forward 'Divider';
9-
@forward 'Dropdown';
10-
@forward 'FieldGroup';
11-
@forward 'FileUploader';
12-
@forward 'Flex';
13-
@forward 'Grid';
14-
@forward 'Header';
15-
@forward 'Item';
16-
@forward 'Modal';
17-
@forward 'Pagination';
18-
@forward 'Pill';
19-
@forward 'Radio';
20-
@forward 'ScrollView';
21-
@forward 'Select';
22-
@forward 'Stack';
23-
@forward 'Tabs';
24-
@forward 'Tag';
25-
@forward 'TextArea';
26-
@forward 'TextField';
27-
@forward 'Toast';
28-
@forward 'Tooltip';
29-
@forward 'UNSTABLE_ActionLayout';
30-
@forward 'UNSTABLE_Avatar';
31-
@forward 'UNSTABLE_EmptyState';
32-
@forward 'UNSTABLE_PartnerLogo';
33-
@forward 'UNSTABLE_ProductLogo';
34-
@forward 'UNSTABLE_Section';
35-
@forward 'UNSTABLE_Slider';
36-
@forward 'UNSTABLE_Toggle';
1+
// This code is commented out until we switch it to the new token system
2+
// @forward 'Accordion';
3+
// @forward 'Alert';
4+
// @forward 'Breadcrumbs';
5+
// @forward 'Button';
6+
// @forward 'Checkbox';
7+
// @forward 'Collapse';
8+
// @forward 'Container';
9+
// @forward 'Divider';
10+
// @forward 'Dropdown';
11+
// @forward 'FieldGroup';
12+
// @forward 'FileUploader';
13+
// @forward 'Flex';
14+
// @forward 'Grid';
15+
// @forward 'Header';
16+
// @forward 'Item';
17+
// @forward 'Modal';
18+
// @forward 'Pagination';
19+
// @forward 'Pill';
20+
// @forward 'Radio';
21+
// @forward 'ScrollView';
22+
// @forward 'Select';
23+
// @forward 'Stack';
24+
// @forward 'Tabs';
25+
// @forward 'Tag';
26+
// @forward 'TextArea';
27+
// @forward 'TextField';
28+
// @forward 'Toast';
29+
// @forward 'Tooltip';
30+
// @forward 'UNSTABLE_ActionLayout';
31+
// @forward 'UNSTABLE_Avatar';
32+
// @forward 'UNSTABLE_EmptyState';
33+
// @forward 'UNSTABLE_PartnerLogo';
34+
// @forward 'UNSTABLE_ProductLogo';
35+
// @forward 'UNSTABLE_Section';
36+
// @forward 'UNSTABLE_Slider';
37+
// @forward 'UNSTABLE_Toggle';

‎packages/web/src/scss/foundation/index.scss‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
@forward '@csstools/normalize.css/normalize.css';
2-
@forward 'box-sizing';
3-
@forward 'images';
4-
@forward 'interactions';
5-
@forward 'links';
6-
@forward 'reset';
7-
@forward 'shared';
8-
@forward 'tokens';
9-
@forward 'typography';
1+
// This code is commented out until we switch it to the new token system
2+
// @forward '@csstools/normalize.css/normalize.css';
3+
// @forward 'box-sizing';
4+
// @forward 'images';
5+
// @forward 'interactions';
6+
// @forward 'links';
7+
// @forward 'reset';
8+
// @forward 'shared';
9+
// @forward 'tokens';
10+
// @forward 'typography';

‎packages/web/src/scss/helpers/index.scss‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
@forward 'accessibility';
2-
@forward 'animations';
3-
@forward 'breakout';
4-
@forward 'images';
5-
@forward 'links';
6-
@forward 'lists';
7-
@forward 'scroll-control';
8-
@forward 'text';
9-
@forward 'typography';
1+
// This code is commented out until we switch it to the new token system
2+
// @forward 'accessibility';
3+
// @forward 'animations';
4+
// @forward 'breakout';
5+
// @forward 'images';
6+
// @forward 'links';
7+
// @forward 'lists';
8+
// @forward 'scroll-control';
9+
// @forward 'text';
10+
// @forward 'typography';

‎packages/web/src/scss/utilities/index.scss‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
@forward 'utilities';
1+
// This code is commented out until we switch it to the new token system
2+
// @forward 'utilities';

‎packages/web/tests/scss.test.ts‎ renamed to ‎packages/web/tests/scss.test-disabled.ts‎

File renamed without changes.

‎tests/e2e/components/demo-modal-compare.spec.ts‎

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -99,25 +99,28 @@ const modalTestConfigs: ModalTestConfig[] = [
9999
const componentName = 'Modal';
100100

101101
const testConfigs: TestConfig[] = [
102-
{
103-
componentName,
104-
componentsDir: '/src/scss/components',
105-
packageName: 'web',
106-
},
107-
{
108-
componentName,
109-
componentsDir: '/src/components',
110-
packageName: 'web-react',
111-
},
102+
// Commented out because we changed tokens and broke utilities, helper and styles used in the demos.
103+
// Should be uncommented in DS-1452 ticket.
104+
// Jan Kryšpín 2024-08-27
105+
// {
106+
// componentName,
107+
// componentsDir: '/src/scss/components',
108+
// packageName: 'web',
109+
// },
110+
// {
111+
// componentName,
112+
// componentsDir: '/src/components',
113+
// packageName: 'web-react',
114+
// },
112115
];
113116

114117
// Disable web-twig tests for now on CI, because we don't have a way to run them in CI yet.
115118
if (!isTestingEnvironment()) {
116-
testConfigs.push({
117-
componentName,
118-
componentsDir: '/components',
119-
packageName: 'web-twig',
120-
});
119+
// testConfigs.push({
120+
// componentName,
121+
// componentsDir: '/components',
122+
// packageName: 'web-twig',
123+
// });
121124
}
122125

123126
testConfigs.forEach(runComponentCompareTests);

‎tests/e2e/demo-components-compare.spec.ts‎

Lines changed: 45 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,51 @@ import { readdirSync } from 'fs';
55
import { formatPackageName, getServerUrl, takeScreenshot, waitForPageLoad } from '../helpers';
66

77
// Tests that are intentionally broken, but will be fixed in the future
8-
const IGNORED_TESTS: string[] = [];
8+
const IGNORED_TESTS: string[] = [
9+
'Accordion',
10+
'Alert',
11+
'Breadcrumbs',
12+
'Button',
13+
'ButtonLink',
14+
'Checkbox',
15+
'Collapse',
16+
'Container',
17+
'Divider',
18+
'Dropdown',
19+
'FieldGroup',
20+
'FileUploader',
21+
'Flex',
22+
'Grid',
23+
'Header',
24+
'Heading',
25+
'Icon',
26+
'Item',
27+
'Link',
28+
'Modal',
29+
'Pagination',
30+
'Pill',
31+
'Radio',
32+
'ScrollView',
33+
'Select',
34+
'Spinner',
35+
'Stack',
36+
'Tabs',
37+
'Tag',
38+
'Text',
39+
'TextArea',
40+
'TextField',
41+
'Toast',
42+
'Tooltip',
43+
'UNSTABLE_ActionLayout',
44+
'UNSTABLE_Avatar',
45+
'UNSTABLE_EmptyState',
46+
'UNSTABLE_PartnerLogo',
47+
'UNSTABLE_ProductLogo',
48+
'UNSTABLE_Section',
49+
'UNSTABLE_Slider',
50+
'UNSTABLE_Toggle',
51+
'UNSTABLE_Truncate',
52+
];
953

1054
interface TestConfig {
1155
packageDir: string;

‎tests/e2e/demo-homepages.spec.ts‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
1-
import { isTesting } from '@lmc-eu/spirit-common/constants/environments';
2-
import { SERVERS, getDevelopmentEndpointUri } from '@lmc-eu/spirit-common/constants/servers';
1+
// import { isTesting } from '@lmc-eu/spirit-common/constants/environments';
2+
// import { SERVERS, getDevelopmentEndpointUri } from '@lmc-eu/spirit-common/constants/servers';
33
import { test } from '@playwright/test';
44
import { takeScreenshot, waitForPageLoad } from '../helpers';
55

66
test.describe('Demo Homepages', () => {
77
const demos = [
8-
{
9-
url: isTesting() ? SERVERS.TESTING.web : getDevelopmentEndpointUri('web', { isDocker: true }),
10-
package: 'web',
11-
},
12-
{
13-
url: isTesting() ? SERVERS.TESTING['web-react'] : getDevelopmentEndpointUri('web-react', { isDocker: true }),
14-
package: 'web-react',
15-
},
8+
// Commented out because we changed tokens and broke utilities, helper and styles used in the demos.
9+
// Can be enabled when new styles are applied to the demos. Or in the DS-1455 ticket.
10+
// Jan Kryšpín 2024-08-27
11+
// {
12+
// url: isTesting() ? SERVERS.TESTING.web : getDevelopmentEndpointUri('web', { isDocker: true }),
13+
// package: 'web',
14+
// },
15+
// {
16+
// url: isTesting() ? SERVERS.TESTING['web-react'] : getDevelopmentEndpointUri('web-react', { isDocker: true }),
17+
// package: 'web-react',
18+
// },
1619
];
1720

1821
for (const demo of demos) {

0 commit comments

Comments
 (0)