Skip to content

Commit d4598ac

Browse files
crishpeenliterat
authored andcommitted
Feat(web): Redo accessibility features of Pagination
1 parent 16281f9 commit d4598ac

File tree

2 files changed

+20
-39
lines changed

2 files changed

+20
-39
lines changed

packages/web/src/scss/components/Pagination/README.md

Lines changed: 12 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,12 @@
33
First item selected:
44

55
```html
6-
<nav role="navigation" aria-label="Pagination Navigation" class="mb-800">
6+
<nav role="navigation" aria-label="Page navigation">
77
<ul class="Pagination">
88
<li class="Pagination__item">
9-
<a
10-
href="#"
11-
class="Pagination__link Pagination__link--current"
12-
aria-label="Current Page, Page 1"
13-
aria-current="page"
14-
>
15-
<span class="accessibility-hidden">page</span>
16-
1
9+
<a href="#" class="Pagination__link Pagination__link--current" aria-current="page">
10+
<span class="accessibility-hidden">Current Page, Page 1</span>
11+
<span aria-hidden="true">1</span>
1712
</a>
1813
</li>
1914
<li class="Pagination__item">
@@ -55,7 +50,7 @@ First item selected:
5550
Middle item selected:
5651

5752
```html
58-
<nav role="navigation" aria-label="Pagination Navigation" class="mb-800">
53+
<nav role="navigation" aria-label="Page navigation">
5954
<ul class="Pagination">
6055
<li class="Pagination__item">
6156
<a href="#" class="Button Button--secondary Button--square">
@@ -78,14 +73,9 @@ Middle item selected:
7873
</a>
7974
</li>
8075
<li class="Pagination__item">
81-
<a
82-
href="#"
83-
class="Pagination__link Pagination__link--current"
84-
aria-label="Current Page, Page 13"
85-
aria-current="page"
86-
>
87-
<span class="accessibility-hidden">page</span>
88-
13
76+
<a href="#" class="Pagination__link Pagination__link--current" aria-current="page">
77+
<span class="accessibility-hidden">Current Page, Page 13</span>
78+
<span aria-hidden="true">13</span>
8979
</a>
9080
</li>
9181
<li class="Pagination__item">
@@ -115,7 +105,7 @@ Middle item selected:
115105
Last item selected:
116106

117107
```html
118-
<nav role="navigation" aria-label="Pagination Navigation" class="mb-800">
108+
<nav role="navigation" aria-label="Page navigation">
119109
<ul class="Pagination">
120110
<li class="Pagination__item">
121111
<a href="#" class="Button Button--secondary Button--square">
@@ -150,14 +140,9 @@ Last item selected:
150140
</a>
151141
</li>
152142
<li class="Pagination__item">
153-
<a
154-
href="#"
155-
class="Pagination__link Pagination__link--current"
156-
aria-label="Current Page, Page 113"
157-
aria-current="page"
158-
>
159-
<span class="accessibility-hidden">page</span>
160-
113
143+
<a href="#" class="Pagination__link Pagination__link--current" aria-current="page">
144+
<span class="accessibility-hidden">Current Page, Page 113</span>
145+
<span aria-hidden="true">113</span>
161146
</a>
162147
</li>
163148
</ul>

packages/web/src/scss/components/Pagination/index.html

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,10 @@
66
<a
77
href="#"
88
class="Pagination__link Pagination__link--current"
9-
aria-label="Current Page, Page 1"
109
aria-current="page"
1110
>
12-
<span class="accessibility-hidden">page</span>
13-
1
11+
<span class="accessibility-hidden">Current Page, Page 1</span>
12+
<span aria-hidden="true">1</span>
1413
</a>
1514
</li>
1615
<li class="Pagination__item">
@@ -74,11 +73,10 @@
7473
<a
7574
href="#"
7675
class="Pagination__link Pagination__link--current"
77-
aria-label="Current Page, Page 13"
7876
aria-current="page"
7977
>
80-
<span class="accessibility-hidden">page</span>
81-
13
78+
<span class="accessibility-hidden">Current Page, Page 13</span>
79+
<span aria-hidden="true">13</span>
8280
</a>
8381
</li>
8482
<li class="Pagination__item">
@@ -142,11 +140,10 @@
142140
<a
143141
href="#"
144142
class="Pagination__link Pagination__link--current"
145-
aria-label="Current Page, Page 113"
146143
aria-current="page"
147144
>
148-
<span class="accessibility-hidden">page</span>
149-
113
145+
<span class="accessibility-hidden">Current Page, Page 113</span>
146+
<span aria-hidden="true">113</span>
150147
</a>
151148
</li>
152149
</ul>
@@ -158,11 +155,10 @@
158155
<a
159156
href="#"
160157
class="Pagination__link Pagination__link--current"
161-
aria-label="Current Page, Page 1"
162158
aria-current="page"
163159
>
164-
<span class="accessibility-hidden">page</span>
165-
1
160+
<span class="accessibility-hidden">Current Page, Page 1</span>
161+
<span aria-hidden="true">1</span>
166162
</a>
167163
</li>
168164
<li class="Pagination__item">

0 commit comments

Comments
 (0)