From 27aaa827b6335291c43e61dfef05a9b3b2eed0ad Mon Sep 17 00:00:00 2001
From: Ondrej Machulda <ondrej.machulda@lmc.eu>
Date: Wed, 17 Mar 2021 01:45:57 +0000
Subject: [PATCH] Add Selenium 4 build to matrix (fixes #272)

---
 .github/workflows/tests.yaml | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
index 12b6a08..5f181b3 100644
--- a/.github/workflows/tests.yaml
+++ b/.github/workflows/tests.yaml
@@ -51,9 +51,12 @@ jobs:
 
   integration-tests:
     runs-on: ubuntu-latest
-    name: Integration tests
-    env:
-      SELENIUM_VERSION: 3.141.59
+
+    strategy:
+      matrix:
+        selenium-version: ['3.141.59', '4.0.0-beta-2']
+
+    name: Integration tests (Selenium ${{ matrix.selenium-version }})
 
     steps:
       - uses: actions/checkout@v2
@@ -70,11 +73,13 @@ jobs:
         run: composer update --no-interaction
 
       - name: Start Selenium server and Xvfb
+        env:
+          SELENIUM_EXTRA_PARAMS: "${{ matrix.selenium-version != '3.141.59' && 'standalone' || '' }}"
         run: |
           google-chrome --version
           chromedriver --version
-          SELENIUM_JAR=$(bin/steward install --no-interaction --no-ansi $SELENIUM_VERSION)
-          xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum java -jar $SELENIUM_JAR -log selenium-server.log &
+          SELENIUM_JAR=$(bin/steward install --no-interaction --no-ansi ${{ matrix.selenium-version }})
+          xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum java -jar $SELENIUM_JAR $SELENIUM_EXTRA_PARAMS >selenium-server.log &
           while ! nc -z localhost 4444 </dev/null; do echo Waiting for Selenium server to start...; sleep 1; done
 
       - name: Run tests