Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sample_weight functionality in pLSA #8

Merged
merged 6 commits into from May 14, 2020
Merged

Implement sample_weight functionality in pLSA #8

merged 6 commits into from May 14, 2020

Conversation

calvinmccarter-at-tempus
Copy link
Contributor

I've added sample_weight as a parameter to fit and fit_transform. In my experiments on both my data and on the newsgroups notebook, it added very little runtime overhead. Please let me know if further testing or documentation in a notebook is needed!

_check_sample_weight was not added to sklearn.utils.validation until v0.22
minor cleanup of imports
@calvinmccarter-at-tempus
Copy link
Contributor Author

@lmcinnes - what do you think about adding sample weights to pLSA? I know this isn't part of the TransformerMixin interface, or in the other sklearn.decomposition methods, but there are lots of settings where this is useful (and also more elegant than over/under-sampling).

@lmcinnes
Copy link
Owner

This looks great -- it certainly makes sense, and I agree that it doesn't have much overhead.

@lmcinnes lmcinnes merged commit be830a2 into lmcinnes:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants