Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#99: port recursion error fix from pynndescent #220

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@jlmelville
Copy link
Contributor

commented Apr 19, 2019

A straight copy of the recursion error fix from lmcinnes/pynndescent#24

The only non-obvious change is to a numba declaration on euclidean_random_projection_split. I don't know whether the simpler UMAP version should take precedence over the pynndescent version or vice versa.

On my Windows machine, this fixes the hang when tested with the data provided by @scharron.

@lmcinnes lmcinnes merged commit 1fa2ff5 into lmcinnes:master Apr 19, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.