Add whitelist to normalizeStoreName to avoid injection#108
Merged
Conversation
This PR introduces a whitelist check to mitigate SQL injection risks when handling user input. Previously, user-controlled input was being used directly in dynamic SQL queries, which could allow an attacker to manipulate database queries. E.g. https://github.com/lmg-anon/mikupad/blob/HEAD/server/server.js#L285
Owner
|
Thank you for your contribution! I didn't care about that at the time because the Mikupad server is supposed to only be used by yourself, but I guess this change doesn't hurt. |
aerodevxp
pushed a commit
to aerodevxp/mikupad
that referenced
this pull request
Jun 8, 2026
Add whitelist to `normalizeStoreName` to avoid injection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a whitelist check to mitigate SQL injection risks when handling user input. Previously, user-controlled input was being used directly in dynamic SQL queries, which could allow an attacker to manipulate database queries. E.g. https://github.com/lmg-anon/mikupad/blob/HEAD/server/server.js#L285