New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #58 | Add Unit Tests for checkorder.js #76

Merged
merged 10 commits into from Oct 17, 2018

Conversation

2 participants
@dgautsch
Contributor

dgautsch commented Oct 9, 2018

This adds unit tests with the Jest test framework. I used node 8.11.x to build this solution. Fixes #58

Further Testing

  • We could test isFileOrdered and compareArr but would then have to export them.
@dgautsch

This comment has been minimized.

Contributor

dgautsch commented Oct 9, 2018

@lnfnunes We'll probably need to change the codacy rules for unit tests, so this passes.

@lnfnunes

Nice job! =)
Just a little typo, then I can merge it
Thanks

jest.restoreAllMocks();
});
it('should idenitfy ordered list links as ordered', () => {

This comment has been minimized.

@lnfnunes

lnfnunes Oct 11, 2018

Owner

Typo idenitfy

This comment has been minimized.

@dgautsch

dgautsch Oct 11, 2018

Contributor

Woops! 🙂

I'll fix that up today.

@dgautsch

This comment has been minimized.

Contributor

dgautsch commented Oct 11, 2018

@lnfnunes ok, fixed the typo :)

dgautsch and others added some commits Oct 11, 2018

@dgautsch

This comment has been minimized.

Contributor

dgautsch commented Oct 16, 2018

@lnfnunes any other changes for this?

@lnfnunes lnfnunes merged commit 2235c56 into lnfnunes:master Oct 17, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lnfnunes

This comment has been minimized.

Owner

lnfnunes commented Oct 17, 2018

Thank you so much @dgautsch

@dgautsch dgautsch deleted the dgautsch:fix/58 branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment