fix: skip decryption for newer devices (e.g. coach, but also mini) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Apr 14, 2021
Owner
|
Thanks! I'll take a better look tomorrow, right now it seems to me that |
lnicola
reviewed
Apr 14, 2021
Owner
|
I just published a new version to crates.io, sorry for the delay. |
Contributor
Author
|
Wow, hey thanks for your work! You saved me a lot of time with this crate(s), thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just got a AirCO2ntrol mini a couple of days ago.
It did not work with the
watchexample, I always got the "invalid message" error.I checked the nodejs implementation and it worked, so I looked deeper into the code, and it looks as if newer Aircontrol minis (and given the comment in the node project also the "coach" model) do not do the pseudo-encryption stuff.
I did not find any documentation/reference besides huhamhire/node-co2-monitor@21458d4.
I implemented the same logic (skipping decryption if the "magic byte" is already present) and now reading the sensor values simply works (and of course matches the values shown on the display).