Skip to content

Fix komga text color#1532

Merged
nyagami merged 1 commit into
lnreader:masterfrom
Soopyboo32:fix-komga-colors
Feb 23, 2025
Merged

Fix komga text color#1532
nyagami merged 1 commit into
lnreader:masterfrom
Soopyboo32:fix-komga-colors

Conversation

@Soopyboo32
Copy link
Copy Markdown
Contributor

No description provided.


// Replace <a> tags with the text inside so its not blue
$('a').each((_, a) => {
$(a).replaceWith($(a).text());
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use plugin custom css instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if that would be better tbh should links even exist in reader

cus u just click on them and the reader gets screwed up
(also most of the a tags in komga shouldent even be detected, in the response they are self closing but html doesent support self closing a tags so the tag just contains the entire rest of the chapter content

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image heres an example

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*self closing tags should be valid btw as the html document is in XML mode that does support self closing tags (hence why the links arent there in browser) but the html parser used doesent seem to support it, even tho its in xml mode

    const $ = parseHTML(htmlString, { xmlMode: true });

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe that does support but cus its also outputting in xml the reader view cant show it cus reader view doesent have the html doctype thing to put it in xml mode

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*there are some properly formatted links sometimes like chapter titles sometimes link back to table of contents, and toc has links ect. but IMO having them be actuall links just makes the reader experience worse cus that is not how you should be navigating the novel (if it even works)

@Soopyboo32 Soopyboo32 requested a review from nyagami February 23, 2025 10:37
@nyagami nyagami merged commit 748b936 into lnreader:master Feb 23, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants