add scripts and description how to test plugins locally#1601
Merged
Conversation
nyagami
reviewed
Mar 30, 2025
| "generate": "node ./scripts/multisrc/generate.js", | ||
| "host-linux": "chmod +x ./host.sh && ./host.sh", | ||
| "host-windows": "powershell ./host.ps1", | ||
| "host-dev": "npx tsc --project tsconfig.production.json && npm run json && npx serve", |
Contributor
Author
There was a problem hiding this comment.
npx command downloads it automatically, it doesn't have to be specified in package.json as a dependency
Member
There was a problem hiding this comment.
So it would be a global package right? I dont think people want it.
Or you could also serve json files via vite by moving them to public folder and change vite server host to 0.0.0.0
Contributor
Author
There was a problem hiding this comment.
I've updated it in a way you have described, however to be honest I still think down the road using npx serve would pay off since it resulted in lesser complexity of json_plugins.js file
Member
There was a problem hiding this comment.
make sense, but could you add the serve package to devDependencies.
nyagami
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.