Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1585411) core: mount-setup: handle non-existing mountpoints gracefully #260

Merged
merged 1 commit into from Feb 11, 2019
Merged

(#1585411) core: mount-setup: handle non-existing mountpoints gracefully #260

merged 1 commit into from Feb 11, 2019

Conversation

dtardon
Copy link
Collaborator

@dtardon dtardon commented Jan 8, 2019

Commit e792e89 ("path-util: don't eat up ENOENT in
path_is_mount_point()") changed path_is_mount_point() so it doesn't hide
-ENOENT from its caller. This causes all boots to fail early in case
any of the mount points does not exist (for instance, when kdbus isn't
loaded, /sys/fs/kdbus is missing).

Fix this by returning 0 from mount_one() if path_is_mount_point()
returned -ENOENT.

(cherry picked from commit b604cb9)

Resolves: #1585411

Copy link
Collaborator

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Commit e792e89 ("path-util: don't eat up ENOENT in
path_is_mount_point()") changed path_is_mount_point() so it doesn't hide
-ENOENT from its caller. This causes all boots to fail early in case
any of the mount points does not exist (for instance, when kdbus isn't
loaded, /sys/fs/kdbus is missing).

Fix this by returning 0 from mount_one() if path_is_mount_point()
returned -ENOENT.

(cherry picked from commit b604cb9)

Resolves: #1585411
@lnykryn lnykryn merged commit 110af4e into lnykryn:staging Feb 11, 2019
@dtardon dtardon deleted the bz1585411-automount branch February 11, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants