Update MatRotation.js #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing some strange results when rotating by low or high or negative numbers on the X Y or Z axis, for example in the Codepen below I have rotated two platforms on the Y axis by 359 and 1 degree so the Red balls should fall and come to a rest on the Blue platforms, instead they roll off in opposite directions. http://codepen.io/pigloo/pen/ZWaBrR/ This piece of code appears to have been ported from here: http://www.euclideanspace.com/maths/geometry/rotations/conversions/eulerToAngle/ but I think there is an error. I am not sure if this effects anything else but from my testing it solves the issue.
|
On further testing this does not seem to solve the issue completely, will get back with more comments soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing some strange results when rotating by low or high or negative numbers on the X Y or Z axis, for example in the Codepen below I have rotated two platforms on the Y axis by 359 and 1 degree so the Red balls should fall and come to a rest on the Blue platforms, instead they roll off in opposite directions.
http://codepen.io/pigloo/pen/ZWaBrR/
This piece of code appears to have been ported from here: http://www.euclideanspace.com/maths/geometry/rotations/conversions/eulerToAngle/ but I think there is an error.
I am not sure if this effects anything else but from my testing it solves the issue.