Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason not using homebrew-core? #6

Open
chenrui333 opened this issue Jun 2, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@chenrui333
Copy link

commented Jun 2, 2019

The k6 formula seems pretty easy to maintain in the homebrew-core?

I am asking because I wonder if we can move it to homebrew-core and I can help maintaining it. :)

@na--

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Moving this to homebew-core would probably be better, and there's a super-old k6 issue about it: loadimpact/k6#380

I have a few questions, since I'm not a Mac/homebrew user:

  • If we remove this formula after it's in homebrew-core, would any existing k6 users that have installed it automagically get the new k6 versions when we release them? Or would they have to re-install k6 from the new formula?
  • How long does it usually take to update a homebrew-core formula when a new version comes out? We usually update this repo as part of the k6 release process, but I see quite a few open PRs in homebrew-core that are weeks old.
  • Does one need to be a Mac/homebrew user in order to submit a pull request for updating a package version in homebrew-core? Looking at the currently open PRs, I can easily create a PR for new k6 versions by hand, but the contributing guidelines only speak in terms of brew commands...
@chenrui333

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

If we remove this formula after it's in homebrew-core, would any existing k6 users that have installed it automagically get the new k6 versions when we release them? Or would they have to re-install k6 from the new formula?

that is really good question, I do not know, I will cross-post this when I submit the PR for discussion and comments. My guess is it needs to be reinstalled.

How long does it usually take to update a homebrew-core formula when a new version comes out? We usually update this repo as part of the k6 release process, but I see quite a few open PRs in homebrew-core that are weeks old.

Should be within half day or one day (PR, build, and merge, and then bottle for helping installation).

Does one need to be a Mac/homebrew user in order to submit a pull request for updating a package version in homebrew-core? Looking at the currently open PRs, I can easily create a PR for new k6 versions by hand, but the contributing guidelines only speak in terms of brew commands...

Yes, everyone can submit PR for keeping it up to date.

@na--

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

that is really good question, I do not know, I will cross-post this when I submit the PR for discussion and comments. My guess is it needs to be reinstalled.

If that's the case, for a few months we probably should continue supporting this repo and updating it when new releases come out, even if it's also in homebrew-core. Do you know if there's a way to inject a warning message in the package, so that when users update it they can see that there's a new homebrew-core package for k6?

@chenrui333

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

Yeah, if that is the case, totally agree with the rollout strategy. :)

@chenrui333 chenrui333 referenced this issue Jun 4, 2019

Closed

k6 0.24.0 (New Formula) #40689

5 of 5 tasks complete
@chenrui333

This comment has been minimized.

Copy link
Author

commented Jun 4, 2019

@na-- Filed a PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.