New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When `k6` interrupts the execution, `WSSessions/WSConnecting/WSSessionDuration`are not reported #333

Closed
ppcano opened this Issue Oct 4, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@ppcano
Member

ppcano commented Oct 4, 2017

The last ws_sessions, ws_connecting, ws_session_duration metric points are not reported when k6 interrupts the execution.

The metrics are included in samples here, but their Sample.Time value will be later than the end of the test and the metrics are not reported.

Running the following test replicates the issue. The console output or selected output won't show the metrics.

I was not able to fix it on the engine. @liclac I can try it again if you tell me how it can be done.

@liclac

This comment has been minimized.

Show comment
Hide comment
@liclac

liclac Oct 4, 2017

Collaborator

Hm. I feel like we need a better solution for filtering out context-cancelled requests than this, because this is a straight up design flaw. I didn't want to do context selects in http.Request, but it may be the only way to ensure final metrics like this are emitted properly.

Collaborator

liclac commented Oct 4, 2017

Hm. I feel like we need a better solution for filtering out context-cancelled requests than this, because this is a straight up design flaw. I didn't want to do context selects in http.Request, but it may be the only way to ensure final metrics like this are emitted properly.

@liclac liclac closed this in f05f33c Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment