Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of commas in environment variable values #1077

Merged
merged 1 commit into from Jul 10, 2019
Merged

Fix handling of commas in environment variable values #1077

merged 1 commit into from Jul 10, 2019

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 10, 2019

This should close #1006

@na-- na-- requested review from mstoykov and sniku July 10, 2019 12:40
mstoykov
mstoykov approved these changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cmd/runtime_options.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   72.79%   72.79%           
=======================================
  Files         133      133           
  Lines        9890     9890           
=======================================
  Hits         7199     7199           
  Misses       2276     2276           
  Partials      415      415
Impacted Files Coverage Δ
cmd/runtime_options.go 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af8e03...4a17722. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 10, 2019 •
edited

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   72.79%   72.79%           
=======================================
  Files         133      133           
  Lines        9890     9890           
=======================================
  Hits         7199     7199           
  Misses       2276     2276           
  Partials      415      415
Impacted Files Coverage Δ
cmd/runtime_options.go 93.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af8e03...4a17722. Read the comment docs.

@na-- na-- merged commit c854389 into master Jul 10, 2019
@na-- na-- deleted the fix-env-var-commas branch July 10, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstoykov mstoykov mstoykov approved these changes

@sniku sniku Awaiting requested review from sniku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI-supplied environment variables can't contain a comma
2 participants
@na-- @mstoykov