New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket `close` event #329

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@ppcano
Member

ppcano commented Oct 3, 2017

This change attempts to fix the close event dispatch.

  • If the VU closes the connection using socket.close, the close event will be fired. A test has been added.

  • If the server closes the connection with status CloseNormalClosure, the close event will be fired instead of an error event. No test for this case.

  • If k6 interrupts the VU execution, k6 will try to close the client connection but the socket event won't be dispatched to the VU (This event didn't work).

@liclac liclac merged commit 8698d4e into loadimpact:master Oct 3, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment