New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: websocket sends automatically a `pong` when `ping` is received #330

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@ppcano
Member

ppcano commented Oct 3, 2017

The WebSocket RFC describes that when receiving a ping the recipient must send back a pong.

Overwriting the default pongHandler disables the pong auto-reply for incoming ping messages. This change brings back the pong auto-reply.

@liclac liclac merged commit f73161e into loadimpact:master Oct 3, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment