New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to alpine golang docker image, bump golang + node versions, migrate to circleci v2 #337

Merged
merged 6 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@StephenRadachy
Contributor

StephenRadachy commented Oct 14, 2017

  • Switched to alpine 3.6 and yarn.
  • Bumped golang and node versions.
  • Switched to circleci v2 since it's new and because the updated dockerfile needs multi-stage support, which started in v17.05.

@StephenRadachy StephenRadachy changed the title from Reduce docker image footprint, increase build speed, and bump golang + node versions to [WIP] Reduce docker image footprint, increase build speed, and bump golang + node versions Oct 14, 2017

@StephenRadachy StephenRadachy changed the title from [WIP] Reduce docker image footprint, increase build speed, and bump golang + node versions to Switch to alpine golang docker image, bump golang + node versions, migrate to circleci v2 Oct 17, 2017

@StephenRadachy

This comment has been minimized.

Show comment
Hide comment
@StephenRadachy

StephenRadachy Oct 17, 2017

Contributor

Right now, the new image is pretty hefty at 564MB, which is due to the addition of node. However, once the web ui is stripped out (and the need for the extra node stage) per #300, the image size will shrink significantly to about 297MB. For context, golang:1.9-alpine itself is 270MB. loadimpact/k6:latest is 334MB

Contributor

StephenRadachy commented Oct 17, 2017

Right now, the new image is pretty hefty at 564MB, which is due to the addition of node. However, once the web ui is stripped out (and the need for the extra node stage) per #300, the image size will shrink significantly to about 297MB. For context, golang:1.9-alpine itself is 270MB. loadimpact/k6:latest is 334MB

@liclac

This comment has been minimized.

Show comment
Hide comment
@liclac

liclac Oct 18, 2017

Collaborator

Wait, you can have multiple FROM's in Dockerfiles now?!

Anyhow, in light of #300, could you straight up remove the Node stuff from the image while we're anyways at it? It's adding a disproportionate amount of build time for something nobody is actually using.

Collaborator

liclac commented Oct 18, 2017

Wait, you can have multiple FROM's in Dockerfiles now?!

Anyhow, in light of #300, could you straight up remove the Node stuff from the image while we're anyways at it? It's adding a disproportionate amount of build time for something nobody is actually using.

@StephenRadachy

This comment has been minimized.

Show comment
Hide comment
@StephenRadachy

StephenRadachy Oct 19, 2017

Contributor

@liclac all set. When this gets merged in, #300 will be 95% done. The last thing will be to remove any looming references within the docs.

I wiped out anything that was related to the web ui. I ended up pointing the / route to the existing mux ping handler.

On a semi-related note - builds are down to under 4 minutes 🎉

Contributor

StephenRadachy commented Oct 19, 2017

@liclac all set. When this gets merged in, #300 will be 95% done. The last thing will be to remove any looming references within the docs.

I wiped out anything that was related to the web ui. I ended up pointing the / route to the existing mux ping handler.

On a semi-related note - builds are down to under 4 minutes 🎉

@@ -24,21 +24,18 @@ import (
"fmt"
"net/http"
"github.com/GeertJohan/go.rice"

This comment has been minimized.

@liclac

liclac Oct 20, 2017

Collaborator

If this is removed, then it needs to be dropped from the rice command in build-dist.sh too.

@liclac

liclac Oct 20, 2017

Collaborator

If this is removed, then it needs to be dropped from the rice command in build-dist.sh too.

This comment has been minimized.

@StephenRadachy

StephenRadachy Oct 20, 2017

Contributor

@liclac ready for liftoff!

cat button press

@StephenRadachy

StephenRadachy Oct 20, 2017

Contributor

@liclac ready for liftoff!

cat button press

@liclac liclac merged commit 6b9ffa6 into loadimpact:master Oct 23, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment