Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with non zero code when setup/teardown timeouts fix #868 #892

Merged
merged 3 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@MStoykov
Copy link
Contributor

MStoykov commented Jan 7, 2019

There are now 4 new non zero exit codes that will be revisioned at later
date when we more exit codes arise.

The 4 new ones are for each of setup and teardown timeouts, if it is a
timeout in the engine but it is not in setup/teardown - no such is known
at this time and 1 for engine error which is not timeout.

Exit with non zero code when setup/teardown timeouts fix #868
There are now 4 new non zero exit codes that will be revisioned at later
date when we more exit codes arise.

The 4 new ones are for each of setup and teardown timeouts, if it is a
timeout in the engine but it is not in setup/teardown - no such is known
at this time and 1 for engine error which is not timeout.

@MStoykov MStoykov requested a review from robingustafsson Jan 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #892 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
- Coverage   69.93%   69.83%   -0.11%     
==========================================
  Files         112      112              
  Lines        8764     8777      +13     
==========================================
  Hits         6129     6129              
- Misses       2238     2251      +13     
  Partials      397      397
Impacted Files Coverage Δ
lib/timeout_error.go 0% <0%> (ø) ⬆️
cmd/run.go 6.4% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7266aed...de14529. Read the comment docs.

@robingustafsson
Copy link
Member

robingustafsson left a comment

LGTM, could you make a numeric const for the "some thresholds have failed" exit code (99) further down in run.go as well?

@MStoykov MStoykov merged commit a1df7bf into master Jan 7, 2019

6 checks passed

ci/circleci: build-docker-images Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-go110 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@MStoykov MStoykov deleted the exitWithErrorCodeWhenSetupTeardownTimeouts branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.