Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud thresholds #894

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
3 participants
@MStoykov
Copy link
Contributor

MStoykov commented Jan 14, 2019

No description provided.

MStoykov added some commits Jan 14, 2019

Report threshold failure correctly to output cloud fix #849
Previously if threshold fails once it marked as failed forever. This is
okay for local run because what we actually report at the end is if the
last threshold check has failed so this threshold failed marking is not
taken into consideration. But the cloud collector and the cloud
collector only takes this as the final result.

This probably should be fixed in some better way such that the final
threshold result is actually given to the collectors to report (if they
do) but this is outside the scope of this commit.

The fix is simply to mark the threshold as failed every time it is
checked this way if it fails once and then it stops failing it will
be marked as not failed again.

@MStoykov MStoykov requested review from robingustafsson and na-- Jan 14, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #894 into master will decrease coverage by <.01%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   69.83%   69.82%   -0.01%     
==========================================
  Files         112      112              
  Lines        8777     8776       -1     
==========================================
- Hits         6129     6128       -1     
  Misses       2251     2251              
  Partials      397      397
Impacted Files Coverage Δ
stats/cloud/collector.go 70.38% <0%> (ø) ⬆️
stats/thresholds.go 93.25% <95%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1df7bf...d5a2d2f. Read the comment docs.

@na--

na-- approved these changes Jan 15, 2019

Copy link
Member

na-- left a comment

LGTM besides the release notes message, 👍 👍 for the comments and the un-exporting of types!

Show resolved Hide resolved release notes/upcoming.md Outdated

@MStoykov MStoykov force-pushed the fixCloudThresholds branch from 6644b21 to d5a2d2f Jan 15, 2019

@MStoykov MStoykov merged commit 8e93f26 into master Jan 15, 2019

6 checks passed

ci/circleci: build-docker-images Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-go110 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@MStoykov MStoykov deleted the fixCloudThresholds branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.