Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--quiet should allow the display of summary stats #937

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@oboukili
Copy link
Contributor

oboukili commented Mar 4, 2019

As the help summary implies:  

-q, --quiet              disable progress updates

The --quiet flag should not prevent summary stats to be displayed

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Mar 4, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #937 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files         118      118           
  Lines        9111     9111           
=======================================
  Hits         6410     6410           
  Misses       2294     2294           
  Partials      407      407
Impacted Files Coverage Δ
cmd/run.go 6.38% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1b259...2572084. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #937 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files         118      118           
  Lines        9111     9111           
=======================================
  Hits         6410     6410           
  Misses       2294     2294           
  Partials      407      407
Impacted Files Coverage Δ
cmd/run.go 6.38% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1b259...2572084. Read the comment docs.

@na-- na-- referenced this pull request Mar 11, 2019

Closed

Fix codecov settings #947

@na--

na-- approved these changes Mar 14, 2019

Copy link
Member

na-- left a comment

Thanks, this LGTM, and sorry for the late reply. There are other things we'd like to fix and fine-tune regarding the --quiet flag (#782), but this is a good start and we'll do the rest in other PRs.

@na-- na-- merged commit a65f09e into loadimpact:master Mar 14, 2019

7 of 8 checks passed

codecov/patch 0% of diff hit (target 70.35%)
Details
ci/circleci: build-docker-images Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-go110 Your tests passed on CircleCI!
Details
codecov/project 70.35% remains the same compared to 0b1b259
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.