Adding placeholder login page (it's ugly) #53
Conversation
|
This is just a proof of concept, we'll replace the login logic with Persona+LDAP in a future PR. |
pdehaan
force-pushed
the
hapi-auth-cookie
branch
from
4c38b16
to
66ac35d
Compare
|
Rebased! |
|
Code basically swiped from https://github.com/hapijs/hapi-auth-cookie/blob/master/example/index.js |
| @@ -36,6 +36,9 @@ | |||
| <!-- --> | |||
| <li class="divider"></li> | |||
| <li><a ng-href="{{ ROUTES.REFERENCE }}">Reference</a></li> | |||
| <!-- --> | |||
| <li class="divider"></li> | |||
| <li><a href="/logout">Logout</a></li> | |||
There was a problem hiding this comment.
Not sure if this /logout route should be added to the {{ ROUTES.LOGOUT }} dict like everything else. I'm rather indifferent, bordering on "meh" (but I am a fan of consistency).
|
For your coding amusement... Baby steps! Next step (and future PR) will be to swap this out for Persona login (relevant links in #53 (comment)). |
|
Checking this out |
|
Works for me! |
|
@rpappalax Did you want to re-review this before somebody presses the green button? Once this is merged, I can ... hell, I'll work on a Convict config PR now and I can rebase it after this is merged. I need more rebase practice anyways. |
|
@pdehaan @kitcambridge Karl and i are going to go ahead and stand up an aws instance for loads-web on mon., and johnnyquestoauth should be OK for now, at least so david can keep working. Before we finish stitching the front and back ends together, however, we should prob have Persona integration finished. loadsv2 can spin up a large num of resources and we want to be safe. |
|
Sounds good, sport! |
refactored the hapi server routes and login template (still ugly)
pdehaan
force-pushed
the
hapi-auth-cookie
branch
from
5f579cf
to
706fee7
Compare
|
rerebased. |
Adding placeholder login page (it's ugly)
No description provided.