New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki
added a commit
that referenced
this pull request
Nov 2, 2018
* Develop (#24) * docs: add npm package badge. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: typo. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: write meaningful tests. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: some cleanup caused by lerna. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * feat: written matrix connector. Fixes #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: lerna bootstrap for circleci. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: enforce installation of olm. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: proper line up workflow Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update README of project Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix badge for first package Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix typo Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update codecov.yml Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki
added a commit
that referenced
this pull request
Nov 2, 2018
* docs: add npm package badge. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: typo. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: write meaningful tests. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: some cleanup caused by lerna. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * feat: written matrix connector. Fixes #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: lerna bootstrap for circleci. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: enforce installation of olm. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: proper line up workflow Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update README of project Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix badge for first package Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix typo Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki
added a commit
that referenced
this pull request
Nov 2, 2018
* docs: add npm package badge. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: typo. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: write meaningful tests. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: some cleanup caused by lerna. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * feat: written matrix connector. Fixes #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: lerna bootstrap for circleci. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: enforce installation of olm. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: proper line up workflow Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update README of project Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix badge for first package Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix typo Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * Codecov (#25) * Develop (#24) * docs: add npm package badge. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: typo. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: write meaningful tests. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: some cleanup caused by lerna. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * feat: written matrix connector. Fixes #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: lerna bootstrap for circleci. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: enforce installation of olm. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: proper line up workflow Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update README of project Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix badge for first package Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix typo Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update codecov.yml Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * Develop (#24) (#27) * docs: add npm package badge. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: typo. Refs #16 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: write meaningful tests. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: some cleanup caused by lerna. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * feat: written matrix connector. Fixes #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: lerna bootstrap for circleci. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * test: enforce installation of olm. Refs #7 Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: proper line up workflow Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: update README of project Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix badge for first package Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> * chore: fix typo Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing some changes
Cool, so just to speed up the process, here are some checks:
npm run lint
npm run test
+ CircleCI agree with yougit commit -s
?If not, run
git rebase -i HEAD_OF_COMMIT_BEFORE_YOURS --signoff
to fix thatAll done? Okay, let us came back to you :-)