Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #24

Merged
merged 14 commits into from Nov 2, 2018
Merged

Develop #24

merged 14 commits into from Nov 2, 2018

Conversation

Ryuno-Ki
Copy link
Contributor

@Ryuno-Ki Ryuno-Ki commented Nov 2, 2018

I am proposing some changes

Cool, so just to speed up the process, here are some checks:

  1. Does the linting pass? npm run lint
  2. Does the tests pass? npm run test + CircleCI agree with you
  3. Is there a signoff? That is, did you git commit -s?
    If not, run git rebase -i HEAD_OF_COMMIT_BEFORE_YOURS --signoff to fix that

All done? Okay, let us came back to you :-)

Ryuno-Ki and others added 14 commits November 2, 2018 12:44
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
@Ryuno-Ki Ryuno-Ki merged commit 500e7c9 into master Nov 2, 2018
Ryuno-Ki added a commit that referenced this pull request Nov 2, 2018
* Develop (#24)

* docs: add npm package badge. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: typo. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: write meaningful tests. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: some cleanup caused by lerna. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* feat: written matrix connector. Fixes #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: lerna bootstrap for circleci. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: enforce installation of olm. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: proper line up workflow

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update README of project

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix badge for first package

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix typo

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update codecov.yml

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki added a commit that referenced this pull request Nov 2, 2018
* docs: add npm package badge. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: typo. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: write meaningful tests. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: some cleanup caused by lerna. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* feat: written matrix connector. Fixes #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: lerna bootstrap for circleci. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: enforce installation of olm. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: proper line up workflow

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update README of project

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix badge for first package

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix typo

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Ryuno-Ki added a commit that referenced this pull request Nov 2, 2018
* docs: add npm package badge. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: typo. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: write meaningful tests. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: some cleanup caused by lerna. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* feat: written matrix connector. Fixes #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: lerna bootstrap for circleci. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: enforce installation of olm. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: proper line up workflow

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update README of project

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix badge for first package

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix typo

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* Codecov (#25)

* Develop (#24)

* docs: add npm package badge. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: typo. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: write meaningful tests. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: some cleanup caused by lerna. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* feat: written matrix connector. Fixes #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: lerna bootstrap for circleci. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: enforce installation of olm. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: proper line up workflow

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update README of project

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix badge for first package

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix typo

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update codecov.yml

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* Develop (#24) (#27)

* docs: add npm package badge. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: typo. Refs #16

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: write meaningful tests. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: some cleanup caused by lerna. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* feat: written matrix connector. Fixes #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: lerna bootstrap for circleci. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* test: enforce installation of olm. Refs #7

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: proper line up workflow

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: update README of project

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix badge for first package

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>

* chore: fix typo

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant