New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs should allow @ (e.g. Medium URLs) #242

Closed
zg opened this Issue Dec 3, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@zg

zg commented Dec 3, 2015

Markdown URLs are currently broken for Medium links: https://lobste.rs/s/2ksjwu/yahoo_and_freebsd/comments/i5m8nr#c_i5m8nr

Here's what I was trying to write (notice "@zg" in the first URL):

I [migrated](https://medium.com/@zg/good-bye-rackspace-hello-digital-ocean-403e7a87228e) from Arch Linux two months ago and have found that it's been the best switch I've made in several years. I'll shamelessly paste some relevant points from a [previous comment](https://lobste.rs/s/cwc1sc/what_are_you_working_on_this_week/comments/5rjeqv#c_5rjeqv) I made:
- Going from rolling release distribution to a more stable environment was a big plus
- FreeBSD has a wealthy amount of [release information](https://www.freebsd.org/releases/) (they’ll tell you what they’re planning and when to expect it)
- The package manager (`pkg`) has been a very simple, yet powerful tool that I’ve gotten used to over the last few weeks
- Packages seem to be easier to setup and are cleaner (I haven’t verified this). I hate that Arch Linux has to have two separate entities, “official packages” and “AUR packages”… This is a frustrating model, in my opinion.
- FreeBSD takes their security very seriously – they have a page dedicated information on security [here](https://www.freebsd.org/security/)
- They have excellent [documentation](https://www.freebsd.org/docs.html)
- They have an excellent [handbook](https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/)

jcs added a commit that referenced this issue Dec 3, 2015

add some tests for Markdowner
including failing ones for bug #209 and bug #242
@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Dec 3, 2015

Contributor

fixed by 6e6803f

Contributor

jcs commented Dec 3, 2015

fixed by 6e6803f

@jcs jcs closed this Dec 3, 2015

@zg

This comment has been minimized.

Show comment
Hide comment
@zg

zg commented Dec 3, 2015

👍

jcs added a commit that referenced this issue Dec 7, 2015

Markdowner: use Nokogiri for html rewriting
brute forcing changes by regexps gets things wrong sometimes, so use
nokogiri to parse the html output of rdiscount and do changes on
individual nodes, then turn back into a string

we lose the ability to move punctuation inside of auto-generated
links, but i don't see any easy/definitive way to do this properly.

closes #242
closes #209

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this issue Jul 11, 2016

add some tests for Markdowner
including failing ones for bug #209 and bug #242

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this issue Jul 11, 2016

Markdowner: use Nokogiri for html rewriting
brute forcing changes by regexps gets things wrong sometimes, so use
nokogiri to parse the html output of rdiscount and do changes on
individual nodes, then turn back into a string

we lose the ability to move punctuation inside of auto-generated
links, but i don't see any easy/definitive way to do this properly.

closes #242
closes #209

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this issue Aug 1, 2016

add some tests for Markdowner
including failing ones for bug #209 and bug #242

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this issue Aug 1, 2016

Markdowner: use Nokogiri for html rewriting
brute forcing changes by regexps gets things wrong sometimes, so use
nokogiri to parse the html output of rdiscount and do changes on
individual nodes, then turn back into a string

we lose the ability to move punctuation inside of auto-generated
links, but i don't see any easy/definitive way to do this properly.

closes #242
closes #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment