Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upURL encoding for specialcharcters won'r work. #419
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Oct 13, 2017
Member
This isn't a bug to be fixed. Not every character is valid in a URL and Story#title_as_url reflects this with the gsub a few lines down: gsub(/[^a-z0-9]/, "_"). If you'd rather leave out the non-ascii characters, replace the "_" with "".
|
This isn't a bug to be fixed. Not every character is valid in a URL and Story#title_as_url reflects this with the gsub a few lines down: |
pushcx
closed this
Oct 13, 2017
pushcx
added
the
question
label
Oct 13, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
roottr
Oct 14, 2017
Hi @pushcx thanks a lot for your response. Would you know also how I can encode turkish character such as title "başakı" to "basaki" ?
Thank you very much in advance.
roottr
commented
Oct 14, 2017
|
Hi @pushcx thanks a lot for your response. Would you know also how I can encode turkish character such as title "başakı" to "basaki" ? Thank you very much in advance. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Oct 15, 2017
Member
It looks like parameterize does this.
This could replace the downcase and maybe some of the use of gsub in title_as_url. I'm reopening this issue, it would be a nice small feature. If you use this on your site, please open a pull request so the main Lobsters code can include it. (If you don't in a week or two, anyone reading this should feel free to do this and I've added the good first issue label.)
|
It looks like This could replace the |
roottr commentedOct 13, 2017
Hello,
It seems Lobster won't correctly encode URl for special characters.
For example:
shows as > s/xociqc/tesla_11_bin_adet_model_x_arac_n_geri_r_yor
should be > s/xociqc/tesla_11_bin_adet_model_x_aracini_geri_cagriyor
Would you know how to fix this?
Thanks a lot in advance.