New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on rails 5.2 defaults after upgrade #509

Closed
thomasdziedzic-pd opened this Issue Jun 13, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@thomasdziedzic-pd
Contributor

thomasdziedzic-pd commented Jun 13, 2018

Restart after each item:

  • Rails.application.config.active_record.cache_versioning = true
  • Rails.application.config.action_dispatch.use_authenticated_cookie_encryption = true
  • Rails.application.config.active_support.use_authenticated_message_encryption = true
  • Rails.application.config.action_controller.default_protect_from_forgery = true
  • Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
  • Rails.application.config.active_support.use_sha1_digests = true
@pushcx

This comment has been minimized.

Show comment
Hide comment
@pushcx

pushcx Jun 14, 2018

Member

Also:

And as an implementation note, if someone wants to tackle any of these, you certainly don't have to do all of them. I'd be very happy to merge PRs for these one-by-one.

Member

pushcx commented Jun 14, 2018

Also:

And as an implementation note, if someone wants to tackle any of these, you certainly don't have to do all of them. I'd be very happy to merge PRs for these one-by-one.

pushcx added a commit that referenced this issue Jun 14, 2018

rails 5.2 upgrade
PR #498, leaves some tasks in #508 and #509

thomasdziedzic-pd added a commit to thomasdziedzic-pd/lobsters that referenced this issue Jun 20, 2018

enable use_authenticated_message_encryption
related issue: lobsters#509

strangely, the option doesn't appear under
http://guides.rubyonrails.org/configuring.html

Seems that lobste.rs does not use MessageEncryptor so enabling this
should effectively do nothing.

@pushcx pushcx closed this in #528 Aug 15, 2018

@pushcx

This comment has been minimized.

Show comment
Hide comment
@pushcx

pushcx Aug 15, 2018

Member

I thanked Thomas in #528, but I want to note for any future readers of this issue that Thomas drove this migration and checked everything off the list in his many PRs.

Member

pushcx commented Aug 15, 2018

I thanked Thomas in #528, but I want to note for any future readers of this issue that Thomas drove this migration and checked everything off the list in his many PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment