New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused data #518

Closed
hyperloop-rails opened this Issue Jun 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hyperloop-rails

hyperloop-rails commented Jun 26, 2018

@showing_user = User.where(:username => params[:username]).first!

the used field of User is is_active, username, is_banned, is_admin, is_modeartor, created_at, invited_by_user, banned_at, banned_by_user, banned_reason, hats, deleted_at, karma, average_karma. and unused fields are : email, email_messages, pushover_messages, and so on.

@pushcx

This comment has been minimized.

Show comment
Hide comment
@pushcx

pushcx Jun 26, 2018

Member

This would be an non-idiomatic, high-maintenance change that would result in brittle code for a negligible performance gain.

If these are coming from a static analysis tool, please just post a meta thread about using it, or put in the human judgment to offer them only where the performance gain is worth the costs.

Member

pushcx commented Jun 26, 2018

This would be an non-idiomatic, high-maintenance change that would result in brittle code for a negligible performance gain.

If these are coming from a static analysis tool, please just post a meta thread about using it, or put in the human judgment to offer them only where the performance gain is worth the costs.

@pushcx pushcx closed this Jun 26, 2018

@pushcx pushcx referenced this issue Jun 28, 2018

Closed

unused data #517

@lobsters lobsters locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.