New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar style on "Newest" page has a weird linebreak #580

antifuchs opened this Issue Oct 20, 2018 · 1 comment


None yet
2 participants

antifuchs commented Oct 20, 2018

On a normally-wide Chrome window, the "Newest" page's nav bar has an odd line break in it:

screen shot 2018-10-20 at 10 42 11

I'm assuming this is because the character widths of the elements on that bar add up to being too wide, but it's still pretty weird. Maybe, as a work-around, "Newest Stories" could be abbreviated, or promoted to the bar somehow?

@pushcx pushcx added the bug label Oct 20, 2018


This comment has been minimized.


pushcx commented Oct 20, 2018

There are a number of pages that exhibit this behavior, like user threads, and this commit fixed a really ugly problem with descriptions being long enough to not just have a funny break but wrap onto two lines. (So, basically every page using @heading.)

So I've been increasingly wanting to redo this header because of these layout issues, but I know changing prominent design elements like the nav is upsetting, so I'd like to do it once rather than incrementally.

I'd like a clear split so the left items are all "user-agnostic site navigation" and the right "personal navigation", meaning "Your Threads" needs to move to the right and possibly even just get dropped in favor of the the new Replies interface. Probably fold Messages into the Replies display so it's not a separate top-level element. When there's replies like "3 Replies", only the number "3" should be red rather than the whole thing, because it's a bit glaring now. We can probably drop the 'Home' that appears on any page that's not the homepage; clicking a site logo to return to the homepage is a well-established pattern on the web. I think we can probably drop the karma display but I know that some users will be dismayed to lose that immediate feedback.

We have a few places we sort of have a subnav going on, like Home/Recent/Newest, Unread/All/Comments/Stories, Messages, and maybe want to create one for Saved/Hidden/Upvoted (I'm pretty sure /hidden and /upvoted are not linked anywhere).

And then, as you point out, we have titles like "Newest Stories" and the site is inconsistent about the use of on-page titles. Submit Story has a title under the nav, Newest Stories has it in the nav while Recent Stories has neither. There isn't a rule that "if you're on the page linked from the header, there's no in-page title, we just bold that link" because Search is both bolded and has a title under the nav. Replies/Messages consistently have a title under the nav so you know which sub-page you're on.

On the flip site, the bottom nav is a grab bag of less-popular, non-personalized links. Probably tags and/or Top (which needs an hint for how to set the time period) should be linked here.

Finally, it would be nice if we had a little elbow room for future expansion.

So there's my braindump about navigation. I'm glad to get my thoughts in one places - does anyone have their own thoughts on navigation and its styling to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment