Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage field? #669

Closed
arp242 opened this issue Apr 30, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@arp242
Copy link
Contributor

commented Apr 30, 2019

What are the thoughts on adding a homepage field for users?

Right now you can already put a link in your profile description, but the advantage of a separate field would be that we can add rel="me", which can be an alternative to e.g. Keybase. It was mentioned by some people in the Keybase discussion; I had never heard of it before, but turns out many services actually add rel="me" (e.g. Twitter, GitHub, etc.) to home page links.

Should be easy to do, and I'll gladly make a PR. Just wanted to check in first to see if there are any objections.

Thanks!

@pushcx

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Sounds good. Please stick it in the User model's typed_store :settings.

@pushcx pushcx added the featurereq label May 1, 2019

arp242 added a commit to arp242/lobsters that referenced this issue May 1, 2019

Add homepage field
Add new homepage field so a rel=me link can be added. Also add rel=me to
the Twitter/GitHub links.

See: http://microformats.org/wiki/rel-me

Closes lobsters#669

arp242 added a commit to arp242/lobsters that referenced this issue May 1, 2019

Add homepage field
Add new homepage field so a rel=me link can be added. Also add rel=me to
the Twitter/GitHub links.

See: http://microformats.org/wiki/rel-me

Closes lobsters#669

arp242 added a commit to arp242/lobsters that referenced this issue May 7, 2019

Add homepage field
Add new homepage field so a rel=me link can be added. Also add rel=me to
the Twitter/GitHub links.

See: http://microformats.org/wiki/rel-me

Closes lobsters#669

@pushcx pushcx closed this in #671 May 8, 2019

pushcx added a commit that referenced this issue May 8, 2019

Add homepage field (#671)
Using URI.parse with IDN/non-ASCII URLs won't work, and as far as I can
find there is no stdlib way of doing it. This regexp should be good enough
and not reject any valid URLs.

Closes #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.