New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: New downvote reason - "Duplicate" #8

Closed
jdan opened this Issue Sep 3, 2012 · 11 comments

Comments

Projects
None yet
6 participants
@jdan
Contributor

jdan commented Sep 3, 2012

I've been seeing a lot of dupe comments lately, and there's no real way to tag them when downvoting.

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Sep 4, 2012

Contributor

I think there is a bug causing the duplicate posts, but I can't reproduce it and I'm not sure if it's just people double clicking the Post button.

Contributor

jcs commented Sep 4, 2012

I think there is a bug causing the duplicate posts, but I can't reproduce it and I'm not sure if it's just people double clicking the Post button.

@jdan

This comment has been minimized.

Show comment
Hide comment
@jdan

jdan Sep 4, 2012

Contributor

How about just a quick validator checking if the comment is identical to one within the last 60 seconds or so?

Contributor

jdan commented Sep 4, 2012

How about just a quick validator checking if the comment is identical to one within the last 60 seconds or so?

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Sep 4, 2012

Contributor

Well I'd rather figure out what is causing the actual problem. If it's double clicking the button, I'll just make the button disable itself after clicking.

Contributor

jcs commented Sep 4, 2012

Well I'd rather figure out what is causing the actual problem. If it's double clicking the button, I'll just make the button disable itself after clicking.

@brycv

This comment has been minimized.

Show comment
Hide comment
@brycv

brycv Sep 4, 2012

Any chance this is related to the "edit comment" issue I was discussing with you earlier? Would there be any possibility that Safari on iOS handles the "click" differently?

brycv commented Sep 4, 2012

Any chance this is related to the "edit comment" issue I was discussing with you earlier? Would there be any possibility that Safari on iOS handles the "click" differently?

@sesh

This comment has been minimized.

Show comment
Hide comment
@sesh

sesh Sep 4, 2012

This happened to me earlier while editing a comment in this thread. I'm fairly sure that it wasn't caused by bonus-clicking the submit button.

I disagree that there should be a downvote reason for "Duplicate" though - I'd prefer that duplicate posts are simply flagged for removal by the moderation team, or the user is notified that someone thinks they double-posted so they can rectify it themselves.

sesh commented Sep 4, 2012

This happened to me earlier while editing a comment in this thread. I'm fairly sure that it wasn't caused by bonus-clicking the submit button.

I disagree that there should be a downvote reason for "Duplicate" though - I'd prefer that duplicate posts are simply flagged for removal by the moderation team, or the user is notified that someone thinks they double-posted so they can rectify it themselves.

@mxswd

This comment has been minimized.

Show comment
Hide comment
@mxswd

mxswd Sep 4, 2012

Contributor

@jcs I'm pretty sure it's people with high ping clicking the button twice.

Throw a sleep 1 in the CommentsController#create and spam click it. It will only show the last one (since it replaces), but when you refresh you will see all of them.

We should disable the button on click.

Contributor

mxswd commented Sep 4, 2012

@jcs I'm pretty sure it's people with high ping clicking the button twice.

Throw a sleep 1 in the CommentsController#create and spam click it. It will only show the last one (since it replaces), but when you refresh you will see all of them.

We should disable the button on click.

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Sep 4, 2012

Contributor

@sesh can you list the steps to reproduce your edit? I can't seem to duplicate it.

Contributor

jcs commented Sep 4, 2012

@sesh can you list the steps to reproduce your edit? I can't seem to duplicate it.

@nexneo

This comment has been minimized.

Show comment
Hide comment
@nexneo

nexneo Sep 4, 2012

@jcs I edited comment twice and I see all 3 comments (1 original, 2 edits) so I had to delete two duplicates.

Links to deleted comments.

https://lobste.rs/s/zkm7r6/activity_since_last_viewing_lobste_rs/comments/s2bmff
https://lobste.rs/s/zkm7r6/activity_since_last_viewing_lobste_rs/comments/14mlch

Hope that helps.

nexneo commented Sep 4, 2012

@jcs I edited comment twice and I see all 3 comments (1 original, 2 edits) so I had to delete two duplicates.

Links to deleted comments.

https://lobste.rs/s/zkm7r6/activity_since_last_viewing_lobste_rs/comments/s2bmff
https://lobste.rs/s/zkm7r6/activity_since_last_viewing_lobste_rs/comments/14mlch

Hope that helps.

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Sep 4, 2012

Contributor

@nexneo Thanks, can you detail exactly what you did? What browser were you on, how long were the edits after the original submission, did you reload in between posting and editing, etc.

Contributor

jcs commented Sep 4, 2012

@nexneo Thanks, can you detail exactly what you did? What browser were you on, how long were the edits after the original submission, did you reload in between posting and editing, etc.

@nexneo

This comment has been minimized.

Show comment
Hide comment
@nexneo

nexneo Sep 4, 2012

@jcs Probably it was as follow. I was using Safari Version 6.0 (8536.22) on Mountain Lion

  • Posted comment
  • 2)After comment appeared below, Clicked on "edit" link just after second or two
  • 3)Changed comment and click update comment
  • Did 2,3 second time
  • Comment appeared updated ( no duplicates visible at this point but I didn't refreshed page )
  • Moved away from page, visited same story again after 2-3 hours and I see 3 comments.

I tried to do that second time in another story but after page refresh only last edit was visible ( I will check again after few hours if previous edit pop up )

nexneo commented Sep 4, 2012

@jcs Probably it was as follow. I was using Safari Version 6.0 (8536.22) on Mountain Lion

  • Posted comment
  • 2)After comment appeared below, Clicked on "edit" link just after second or two
  • 3)Changed comment and click update comment
  • Did 2,3 second time
  • Comment appeared updated ( no duplicates visible at this point but I didn't refreshed page )
  • Moved away from page, visited same story again after 2-3 hours and I see 3 comments.

I tried to do that second time in another story but after page refresh only last edit was visible ( I will check again after few hours if previous edit pop up )

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Sep 4, 2012

Contributor

Thanks, I was able to reproduce the problem with Safari. Hopefully this is now fixed in 17ce13d

Contributor

jcs commented Sep 4, 2012

Thanks, I was able to reproduce the problem with Safari. Hopefully this is now fixed in 17ce13d

@jcs jcs closed this Sep 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment