New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate if a story has a description #227

Merged
merged 3 commits into from Nov 5, 2015

Conversation

Projects
None yet
2 participants
@pushcx
Member

pushcx commented Oct 3, 2015

To encourage folks to write story descriptions on links, let's mark stories with descriptions so that folks know to click through.

The pilcrow is a little visually heavy, but it seemed better than an arbitrary symbol.

Indicate if a story has a description
To encourage folks to write story descriptions on links, let's mark stories with descriptions so that folks know to click through.

The pilcrow is a little visually heavy, but it seemed better than an arbitrary symbol.
@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Oct 11, 2015

Contributor
ActionView::Template::Error (undefined method `markdown_description' for #<Story:0x007fcfa3cc5bd0>):

I think you mean markeddown_description.

Contributor

jcs commented Oct 11, 2015

ActionView::Template::Error (undefined method `markdown_description' for #<Story:0x007fcfa3cc5bd0>):

I think you mean markeddown_description.

@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Nov 4, 2015

Contributor

just for posterity:

[11/04 10:34] <jcs> yeah i don't like that character but i'm not opposed to showing something in some way when there is text
[11/04 10:34] <jcs> and i don't know what else to show so i have not updated the pr
[11/04 10:35] <jcs> maybe just another tag-like thing? i don't know
[11/04 10:35] <pushcx> Ha! I also don't like that character, but failed to think of something more appropriate.
Contributor

jcs commented Nov 4, 2015

just for posterity:

[11/04 10:34] <jcs> yeah i don't like that character but i'm not opposed to showing something in some way when there is text
[11/04 10:34] <jcs> and i don't know what else to show so i have not updated the pr
[11/04 10:35] <jcs> maybe just another tag-like thing? i don't know
[11/04 10:35] <pushcx> Ha! I also don't like that character, but failed to think of something more appropriate.
move before tags, use different symbol
Pilcrow is ugly. Alternates: *, †, ‡, §

jcs added a commit that referenced this pull request Nov 5, 2015

Merge pull request #227 from pushcx/patch-1
Indicate if a story has a description

@jcs jcs merged commit 72fc702 into lobsters:master Nov 5, 2015

jcs added a commit that referenced this pull request Nov 5, 2015

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this pull request Jul 11, 2016

Merge pull request #227 from pushcx/patch-1
Indicate if a story has a description

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this pull request Jul 11, 2016

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this pull request Aug 1, 2016

Merge pull request #227 from pushcx/patch-1
Indicate if a story has a description

SiDevesh pushed a commit to RedCarpetUp/lobsters that referenced this pull request Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment