Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd comment tree lines #233
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jcs
Oct 26, 2015
Contributor
I have something similar to that in a local tree but it's not accurate.
Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.png
Notably the line goes all the way up along the left to the parent vote count, and the collapse links are moved onto the line. For the last child node of each branch, the line stops.
Sort of like Windows Explorer or whatever else uses this kind of tree:
|
I have something similar to that in a local tree but it's not accurate. Here is what yours looks like: https://i.imgur.com/SXYiWft.png Notably the line goes all the way up along the left to the parent vote count, and the collapse links are moved onto the line. For the last child node of each branch, the line stops. Sort of like Windows Explorer or whatever else uses this kind of tree: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
AndrewBrinker
Oct 26, 2015
You're right. Your version looks better.
On Mon, Oct 26, 2015 at 7:27 PM, joshua stein notifications@github.com
wrote:
I have something similar to that in a local tree but it's not accurate.
Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.pngNotably the line goes all the way up along the left to the parent vote
count, and the collapse links are moved onto the line. For the last child
node of each branch, the line stops.Sort of like Windows Explorer or whatever else uses this kind of tree:
http://i.imgur.com/cZ1YDaC.png
—
Reply to this email directly or view it on GitHub
#233 (comment).
AndrewBrinker
commented
Oct 26, 2015
|
You're right. Your version looks better. On Mon, Oct 26, 2015 at 7:27 PM, joshua stein notifications@github.com
|
AndrewBrinker commentedOct 26, 2015
This commit closes issue #189, adding a line to the left of each comment to
assist with identifying which comments are nested where in a larger
conversation.