New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment tree lines #233

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@AndrewBrinker

AndrewBrinker commented Oct 26, 2015

This commit closes issue #189, adding a line to the left of each comment to
assist with identifying which comments are nested where in a larger
conversation.

Added comment tree lines
This commit closes issue #189, adding a line to the left of each comment to
assist with identifying which comments are nested where in a larger
conversation.
@jcs

This comment has been minimized.

Show comment
Hide comment
@jcs

jcs Oct 26, 2015

Contributor

I have something similar to that in a local tree but it's not accurate.

Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.png

Notably the line goes all the way up along the left to the parent vote count, and the collapse links are moved onto the line. For the last child node of each branch, the line stops.

Sort of like Windows Explorer or whatever else uses this kind of tree:

http://i.imgur.com/cZ1YDaC.png

Contributor

jcs commented Oct 26, 2015

I have something similar to that in a local tree but it's not accurate.

Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.png

Notably the line goes all the way up along the left to the parent vote count, and the collapse links are moved onto the line. For the last child node of each branch, the line stops.

Sort of like Windows Explorer or whatever else uses this kind of tree:

http://i.imgur.com/cZ1YDaC.png

@AndrewBrinker

This comment has been minimized.

Show comment
Hide comment
@AndrewBrinker

AndrewBrinker Oct 26, 2015

You're right. Your version looks better.

On Mon, Oct 26, 2015 at 7:27 PM, joshua stein notifications@github.com
wrote:

I have something similar to that in a local tree but it's not accurate.

Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.png

Notably the line goes all the way up along the left to the parent vote
count, and the collapse links are moved onto the line. For the last child
node of each branch, the line stops.

Sort of like Windows Explorer or whatever else uses this kind of tree:

http://i.imgur.com/cZ1YDaC.png


Reply to this email directly or view it on GitHub
#233 (comment).

AndrewBrinker commented Oct 26, 2015

You're right. Your version looks better.

On Mon, Oct 26, 2015 at 7:27 PM, joshua stein notifications@github.com
wrote:

I have something similar to that in a local tree but it's not accurate.

Here is what yours looks like: https://i.imgur.com/SXYiWft.png
Here's a mockup of what I would like: https://i.imgur.com/677PsUV.png

Notably the line goes all the way up along the left to the parent vote
count, and the collapse links are moved onto the line. For the last child
node of each branch, the line stops.

Sort of like Windows Explorer or whatever else uses this kind of tree:

http://i.imgur.com/cZ1YDaC.png


Reply to this email directly or view it on GitHub
#233 (comment).

@jcs jcs closed this Dec 7, 2015

@talklittle talklittle referenced this pull request Sep 25, 2017

Merged

Comment tree lines #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment