Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate .travis.yml #412
Conversation
hmadison
added some commits
Oct 4, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
talklittle
Oct 4, 2017
Contributor
Awesome! Maybe add the badge to the README while you're at it?
[](https://travis-ci.org/lobsters/lobsters)
|
Awesome! Maybe add the badge to the README while you're at it? |
spec/models/user_spec.rb
| @@ -6,7 +6,7 @@ | ||
| expect { User.make!(:username => "") }.to raise_error | ||
| expect { User.make!(:username => "*") }.to raise_error | ||
| User.make!(:username => "test") | ||
| User.make!(:username => "test") unless User.find_by(username: 'test') |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Oct 5, 2017
Member
Why is this needed? Is this papering over a test failing to clean the database?
pushcx
Oct 5, 2017
Member
Why is this needed? Is this papering over a test failing to clean the database?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hmadison
Oct 5, 2017
Contributor
This fixed a failure on two runs:
- https://travis-ci.org/lobsters/lobsters/builds/283332809?utm_source=github_status&utm_medium=notification
- https://travis-ci.org/lobsters/lobsters/builds/283330930?utm_source=github_status&utm_medium=notification
We have transnational fixtures turned on, so we should be clearing the database after each run.
hmadison
Oct 5, 2017
Contributor
This fixed a failure on two runs:
- https://travis-ci.org/lobsters/lobsters/builds/283332809?utm_source=github_status&utm_medium=notification
- https://travis-ci.org/lobsters/lobsters/builds/283330930?utm_source=github_status&utm_medium=notification
We have transnational fixtures turned on, so we should be clearing the database after each run.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Oct 5, 2017
Member
Uh... that sure looks like either test data failed to get cleaned or some general pre-test hook is creating duplicate data. There's something wrong here, this unless shouldn't exist. I'm sorry I didn't think of this before hitting merge.
pushcx
Oct 5, 2017
Member
Uh... that sure looks like either test data failed to get cleaned or some general pre-test hook is creating duplicate data. There's something wrong here, this unless shouldn't exist. I'm sorry I didn't think of this before hitting merge.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hmadison
Oct 5, 2017
Contributor
Ill dig at this more locally and try to see whats causing the issue.
hmadison
Oct 5, 2017
Contributor
Ill dig at this more locally and try to see whats causing the issue.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks, this is great to have on PRs. |
pushcx
closed this
Oct 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Oct 5, 2017
Member
Reopening so I can't forget about the unless again. @hmadison, please reuse this PR if you can land a fix on your travis--conf branch. Hopefully GitHub does the right thing... it looks like reopening deleted the merge commit, which is an OK approach.
|
Reopening so I can't forget about the |
pushcx
reopened this
Oct 5, 2017
.travis.yml
| services: | ||
| - mysql | ||
| env: | ||
| - DATABASE_URL=mysql2://root:@localhost/lobsters_test |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hmadison
Oct 5, 2017
Contributor
@pushcx The issue was the seeds.rb file had a definition for the test user which was getting loaded in before the test run.
|
@pushcx The issue was the seeds.rb file had a definition for the test user which was getting loaded in before the test run. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Great, thank you for running that down! |
hmadison commentedOct 4, 2017
Sets up services needed for test.