Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake SMTP settings configurable from the env #446
Conversation
pushcx
merged commit 4603cae
into
lobsters:master
Jan 30, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
pushcx
Jan 30, 2018
Member
This looks totally reasonable, thanks. In prod, postfix is listening to the local port.
|
This looks totally reasonable, thanks. In prod, postfix is listening to the local port. |
avinassh
deleted the
avinassh:patch-2
branch
Jan 30, 2018
added a commit
that referenced
this pull request
Mar 28, 2018
added a commit
that referenced
this pull request
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
avinassh commentedJan 20, 2018
The changes made here does not affect how the older SMTP settings were configured. I have kept the earlier values as default and code won't break even if none of the environment values is not set.
I am curious how main lobsters site is running in production. Does this file is manually overwritten during deployment?