Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid require memory leak with pathnames in load path #449
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
|
added a commit
to jrafanie/openproject
that referenced
this pull request
Jan 26, 2018
jrafanie
referenced this pull request
Jan 26, 2018
Merged
Avoid require memory leak with pathnames in load path #6148
added a commit
to jrafanie/errbit
that referenced
this pull request
Jan 26, 2018
jrafanie
referenced this pull request
Jan 26, 2018
Merged
Avoid require memory leak with pathnames in load path #1257
added a commit
to jrafanie/errbit
that referenced
this pull request
Jan 26, 2018
added a commit
to opf/openproject
that referenced
this pull request
Jan 28, 2018
added a commit
to opf/openproject
that referenced
this pull request
Jan 29, 2018
pushcx
merged commit 14a8b03
into
lobsters:master
Jan 30, 2018
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Jan 30, 2018
Member
Thanks for this small workaround. I'd just bump to Ruby 2.5, but Ubuntu doesn't yet have a package for the LTS we're on (xenial).
|
Thanks for this small workaround. I'd just bump to Ruby 2.5, but Ubuntu doesn't yet have a package for the LTS we're on (xenial). |
jrafanie
deleted the
jrafanie:avoid_memory_leak_with_require_and_pathnames_in_load_path
branch
Jan 30, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jrafanie
Jan 30, 2018
Contributor
@pushcx Good point. Honestly though, there are optimizations/caching done for string $LOAD_PATH objects that aren't done for pathname so even on 2.5.0, it's faster to use strings in the load path.
|
@pushcx Good point. Honestly though, there are optimizations/caching done for string $LOAD_PATH objects that aren't done for pathname so even on 2.5.0, it's faster to use strings in the load path. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Jan 30, 2018
Member
Oh, cool. Thank you for pointing that out, I'm happy to have a little perf improvement.
|
Oh, cool. Thank you for pointing that out, I'm happy to have a little perf improvement. |
jrafanie commentedJan 26, 2018
Any ruby requires that occur in your application will leak with
Pathnames in the $LOAD_PATH in ruby 2.3/2.4. Beyond that, it's faster
to use strings in the load path. Please join this bug and add your
support for a fix:
https://bugs.ruby-lang.org/issues/14372