Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configurable open signups #455

Merged
merged 10 commits into from
Mar 21, 2018
Merged

Feature: Configurable open signups #455

merged 10 commits into from
Mar 21, 2018

Conversation

avinassh
Copy link
Contributor

@avinassh avinassh commented Feb 3, 2018

This PR lets you have complete open sign ups and is configurable with an env var. Set OPEN_SIGNUPS=true, any other string or absence of this env will be considered as false. So, existing Lobsters instance will run as expected.

Changes:

  1. If OPEN_SIGNUPS is not set or set to any value other than true, app works like earlier.
  2. If OPEN_SIGNUPS is set to true, in the header there will be an item Sign Up Now and in footer Join <site name>, they both point to /invitations/open.
  3. I added a new CSS class signup-text which can be used to customize Sign Up Now text in header.

@avinassh
Copy link
Contributor Author

avinassh commented Feb 3, 2018

Screenshot:

screen shot 2018-02-03 at 2 39 24 pm

@avinassh
Copy link
Contributor Author

@pushcx any update on this PR?

@pushcx pushcx merged commit 4e784cd into lobsters:master Mar 21, 2018
@pushcx
Copy link
Member

pushcx commented Mar 21, 2018

Thanks!

@avinassh avinassh deleted the signup branch December 19, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants