Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfilter by tag and domain when searching for comments #501
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Jun 13, 2018
Member
Any followers: there was significant discussion of this over in #502 and some offline discussion between David and I planning to redesign Story.domain and searching. This PR will change significantly (or just be closed + replaced, if making a new branch looks easier to David) before merging.
pushcx
commented
Jun 13, 2018
•
edited
Edited 1 time
-
pushcx
edited Jun 13, 2018 (most recent)
-
pushcx
created Jun 13, 2018
edited
-
Jun 13, 2018 (most recent) -
Jun 13, 2018
|
Any followers: there was significant discussion of this over in #502 and some offline discussion between David and I planning to redesign |
added a commit
that referenced
this pull request
Jun 27, 2018
pushcx
referenced this pull request
Jun 27, 2018
Closed
Comment search doesn't use tag/domain scope. #491
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pushcx
Aug 14, 2018
Member
David - any chance you're settled in your new gig and want to take a run at an exciting merge conflict to add these tests?
|
David - any chance you're settled in your new gig and want to take a run at an exciting merge conflict to add these tests? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
david-wolgemuth
Aug 14, 2018
Contributor
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
david-wolgemuth
Aug 15, 2018
Contributor
@pushcx - rebased on master!
I added gem "rb-readline" to the development/test group to fix a byebug issue. I think it might have been introduced during the rails upgrade?
|
@pushcx - rebased on master! I added |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Cool, thanks for these tests! |
david-wolgemuth commentedJun 11, 2018
Fix to issue #491 Comment search doesn't use tag/domain scope..