Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operational wording of error messages on HTTP error pages. #576

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

alanpost
Copy link
Contributor

The error message wording on the 500 page isn't suitable for a site with the traffic lobste.rs now receives. This patch makes the wording more descriptive and idiomatic, as well as providing guidance for reporting server side errors.

@alanpost
Copy link
Contributor Author

If you'd rather have a PR moving these pages from lobsters.git to lobsters-ansible.git let me know; I could make the case they belong in that repository by comparison to the about page. Unlike that page, however, these must exist on any deployment of the codebase.

@pushcx
Copy link
Member

pushcx commented Nov 7, 2018

Thanks for these.

I'm actually tempted to go the other direction, bring in the about and other pages from the ansible repo to here. There's already a hundred places someone needs to remove the name "Lobsters" and otherwise customize to set up a sister site; a couple more is no big deal and probably actually helpful for understanding what files to put where to have a running site.

@pushcx pushcx merged commit d11da23 into lobsters:master Nov 7, 2018
@alanpost alanpost mentioned this pull request Apr 11, 2019
@pushcx
Copy link
Member

pushcx commented Apr 17, 2019

Based on this + our other conversations I moved the assets + history over in 2fe67dc.

@alanpost alanpost deleted the status-wording branch May 4, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants