Admin: Add Release workflow #21
Conversation
Makefile
Outdated
| touch $(VENV_DIR)/bin/activate | ||
|
|
||
| install: venv | ||
| install: $(VENV_ACTIVATE) |
There was a problem hiding this comment.
Running make install on my machine didn't actually do anything - it just said:
make: Nothing to be done for 'install'.
I don't know why, or whether this is a system-specific thing? But it does work using the $(VENV_ACTIVATE) command, both locally and in the CI
There was a problem hiding this comment.
For what I can see, the make target dependencies are: install -> venv -> .venv/bin/activate -> pyproject.toml
We should add all non-file-targets to the .PHONY, but I don't think that would make a difference.
I think in your case it's really just that the change date of .venv/bin/activate is later than pyproject.toml? In this case make would detect that .venv/bin/activate is newer than the pyproject.toml (so it does not have to be rebuilt).
This in turn means that the venv and the install targets do not have to be executed.
But that actually might be correct in this case?
If you want to make sure that the install target is always executed, then I would recommend to move the editable pip install command to the install target and add the install target to .PHONY.
There was a problem hiding this comment.
I should have specified actually that make install didn't do anything - despite the fact that there was no .venv on my system. Running make install lint would then fail, because the linter could not be executed without a virtual environment.
However, I cannot reproduce this anymore. Everything now suddenly works as it should, so I've reverted this change.
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Nice! This is looking great! 🤩
Thanks for streamlining the release of the package here. I think this should reduce the turnover time for the other PRs you might have out there, and help get changes out! 💯
| environment: | ||
| name: pypi | ||
| url: https://pypi.org/p/localstack-snapshot |
There was a problem hiding this comment.
praise: Nice! Following best practices here with the env! I added this env + workflow + repo as trusted publisher to the project on PyPi!
bblommers
force-pushed
the
admin-release-workflow
branch
from
42544c5 to
cab9e53
Compare
|
Thanks for helping out @alexrashed, despite being OOO! I just managed to release 0.3.1, so it looks like everything works OK 👍 |
This should make it a little easier to release this library.
If we go ahead with this, we will probably need to configure PyPi and add this library to the list of Trusted Publishers.
FYI @alexrashed as our CI expert 🙂