Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HTTP HEAD method operation detection in ASF #5991

Merged
merged 1 commit into from May 3, 2022
Merged

fix HTTP HEAD method operation detection in ASF #5991

merged 1 commit into from May 3, 2022

Conversation

alexrashed
Copy link
Member

This PR fixes the HTTP HEAD method detection in the ASF operation router for service with a rest-* protocol.

A new inheritance layer has been introduced (_StrictMethodRule) which reverts assumptions made by Werkzeug's rule, specifically the automatic adding of HEAD to the list of methods if the methods param contains GET (werkzeug/routing.py#L723-L724).

@alexrashed @thrau
fix HTTP HEAD method operation detection in ASF
fb3f218 
Co-authored-by: Thomas Rausch <thomas@thrau.at>
@alexrashed alexrashed requested a review from thrau as a code owner May 3, 2022 07:27
@alexrashed alexrashed temporarily deployed to localstack-ext-tests May 3, 2022 07:27 Inactive
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 92.225% when pulling fb3f218 on fix-http-head-op-detection into 65468b7 on master.

@github-actions
Copy link

github-actions bot commented May 3, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 3m 22s ⏱️ + 2m 37s
   982 tests ±0     942 ✔️ ±0  40 💤 ±0  0 ❌ ±0 
1 206 runs  ±0  1 138 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit fb3f218. ± Comparison against base commit 65468b7.

thrau
thrau approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

@thrau thrau merged commit 77bd9e3 into master May 3, 2022
@thrau thrau deleted the fix-http-head-op-detection branch May 3, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexrashed @coveralls @thrau