move import_rest_api patch into ASF handler #6048
Conversation
|
|
||
| Ripped :call_moto_with_request: from moto.py but applicable to any operation (operation_name). | ||
| """ | ||
| local_context = create_aws_request_context( |
There was a problem hiding this comment.
Cool! Looks quite useful - since this is generally applicable, I'd probably move this to moto.py. (as a generalization of call_moto_with_request, which can then call this function with operation_name=context.operation.name).
There was a problem hiding this comment.
So this was result of a conversation with @thrau, we don't necessarilly think this will be the pattern to use, hence kept it close where it's used. Moving it to the moto.py is not problem for me, but might result in being spread unnecessarily?
| "PutRestApi", | ||
| PutRestApiRequest( | ||
| restApiId=response.get("id"), | ||
| failOnWarnings=str_to_bool(fail_on_warnings) or False, |
There was a problem hiding this comment.
Out of curiosity - can the runtime type of fail_on_warnings be str here, did you actually observe this behavior?
There was a problem hiding this comment.
It's a string and easy observable running the following command.
awslocal apigateway import-rest-api --cli-binary-format raw-in-base64-out --fail-on-warnings --body 'file:///spec.json
There was a problem hiding this comment.
LGTM!
I'm OK with merging the PR as is if we leave _call_moto closed in the module. A generalization of the way it is now is not great imo. It's not clear from the interface what exactly from the request context that is being passed to _call_moto is being re-used (and why i would want that in the first place). We're passing down headers from the original request that may not belong to the subsequent or may even cause parser errors if passing unexpected headers.
Small PR to move the
import_rest_apioperation to the ASF handler. Doing that, we can remove our internal monkey patching.