fix pycharm unit test debug execution by renaming http package #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the module
unit.httptounit.http_.It fixes a developer experience issue where unit tests in the "root" folder of the unit tests could not be executed in debug mode in PyCharm.
You can easily reproduce this by trying to execute any test in the
unitfolder in debug mode using PyCharm's pytest integration (f.e.test_generic_proxy).PyCharm tries to load the
httpmodule (which contains unit tests for thelocalstack.httpmodule) instead of the builtinhttpmodule.PyCharm YouTrack Issue: https://youtrack.jetbrains.com/issue/PY-54265