Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cloudwatch tests by filtering alarm names #7277

Merged
merged 1 commit into from Dec 2, 2022
Merged

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Dec 2, 2022

Motivation

Currently, on master, tests are failing due to the put_metric_alarm_escape_character test failing.
Since it describes all alarms in the describe_alarms check, and just takes the first, it is very possible a leftover alarm from another test failing this one.

Changes

  • use cleanups fixture for cleanup of this alarm
  • filter describe alarms so the first returned alarm should always be the just-created one.

@dfangl dfangl requested a review from steffyP as a code owner December 2, 2022 16:37
@dfangl dfangl temporarily deployed to localstack-ext-tests December 2, 2022 16:37 Inactive
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   51m 32s ⏱️ - 28m 5s
1 528 tests  -   16  1 252 ✔️  -   26  275 💤 +    9  1 +1 
1 528 runs   - 644  1 252 ✔️  - 394  275 💤  - 251  1 +1 

For more details on these failures, see this check.

Results for commit 852d49f. ± Comparison against base commit 732a8e7.

@dfangl dfangl requested a review from simonrw December 2, 2022 18:29
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfangl dfangl merged commit 3bdbf44 into master Dec 2, 2022
@dfangl dfangl deleted the fix-cloudwatch-tests branch December 2, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants