Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1 provider aliases for legacy providers #7875

Merged
merged 1 commit into from Mar 15, 2023
Merged

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Mar 15, 2023

Since we currently have been advertising the newer provider implementations as v2, users might try to "revert" to the legacy provider by setting the PROVIDER_OVERRIDE_<svc> variable to v1. Unfortunately this will currently fail since they need to remove the variable completely.

This PR now introduces v1 aliases for the legacy (currently still default) providers with a v2 provider, i.e. lambda, s3 and stepfunctions

cc @bentsku @dfangl

@dominikschubert dominikschubert self-assigned this Mar 15, 2023
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests March 15, 2023 09:51 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage: 85.094% (-0.01%) from 85.109% when pulling ff0594a on add-v1-provider-aliases into 3cb5069 on master.

@github-actions
Copy link

LocalStack integration with Pro

       2 files   -     1         2 suites   - 1   1h 43m 7s ⏱️ +47s
1 798 tests ±    0  1 413 ✔️  -     3  385 💤 +    3  0 ±0 
2 153 runs   - 371  1 588 ✔️  - 202  565 💤  - 169  0 ±0 

Results for commit ff0594a. ± Comparison against base commit 3cb5069.

@dominikschubert dominikschubert marked this pull request as ready for review March 15, 2023 18:32
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea! we'll probably see this pattern a few more times moving forward, so maybe makes sense to introduce this as first class citizen into the provider plugins.

@thrau thrau merged commit 31c2825 into master Mar 15, 2023
23 of 24 checks passed
@thrau thrau deleted the add-v1-provider-aliases branch March 15, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants