Dashboard sometimes loads with odd width #378

Closed
philipn opened this Issue Nov 21, 2012 · 2 comments

Projects

None yet

2 participants

@philipn
Member
philipn commented Nov 21, 2012

I think this has to do with the time the events fire.

Noticing this some of the time in Firefox on https://scruzwiki.org (which has the latest master w/ turbodashboard merged)

img

Tagging @rtucker

@rtucker
rtucker commented Nov 21, 2012

I can reproduce it as well, with Chrome. Rats. JavaScript is not my
forte, so I'm not too surprised things got weird. I will poke around with
it over the weekend. -rt

On Tue, Nov 20, 2012 at 7:24 PM, Philip Neustrom
notifications@github.comwrote:

I think this has to do with the time the events fire.

Noticing this some of the time in Firefox on https://scruzwiki.org (which
has the latest master w/ turbodashboard merged)

[image: img]https://a248.e.akamai.net/camo.github.com/d14935cae99426a7c0aabff8eca040f21a63ce82/687474703a2f2f6661726d392e737461746963666c69636b722e636f6d2f383438322f383230333636303130395f323636623738616239345f622e6a7067

Tagging @rtucker https://github.com/rtucker


Reply to this email directly or view it on GitHubhttps://github.com/localwiki/localwiki/issues/378.

Ryan Tucker rtucker@gmail.com

@rtucker rtucker added a commit to rtucker/localwiki that referenced this issue Nov 23, 2012
@rtucker rtucker Adjust ordering of dashboard loads to avoid races
Start loading the graphs after the summary is received (and
the entire stats page is visible), so that we don't end up in
a case where the graphs are hidden while being generated.

Have not been able to reproduce #378 with this in place.
df18498
@rtucker
rtucker commented Nov 23, 2012

Commit df18498 seems to fix it... I believe the graph data would sometimes load before the summary numbers, and thus the $.plot() would occur before the stats div was .show()'d.

Haven't seen the problem happen since this, going to submit a pull request to see if that makes it start happening again :-)

@philipn philipn closed this Nov 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment